feat(webapp): modernize development tooling - replace webpack, craco, with vite #413
Conversation
… with vite and add support for tailwindcss
|
@benpsnyder is attempting to deploy a commit to the Bigcapital Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
To reduce the new additions on this PR, I suggest it would better if we split the replacing class to className part to separate PR. I would do tomorrow if you're busy. @benpsnyder
| @@ -7,25 +6,27 @@ import { SubscriptionPlansSection } from './SubscriptionPlansSection'; | |||
| import withSubscriptionPlansActions from '../../Subscriptions/withSubscriptionPlansActions'; | |||
| import styles from './SetupSubscription.module.scss'; | |||
|
|
|||
| // TODO: use typescript https://github.com/NuroDev/lemonsqueezy.ts/tree/main/src/modules/subscription#-subscription | |||
There was a problem hiding this comment.
@abouolia kindly make the lemonsqueezy implementation type-safe. I had to disable this to get Vite to run. I can't test this functionality so I don't want to try to restore the functionality
Yes, the bulk of the file changes is a simple change from if you leave it as changed to |
benpsnyder
force-pushed
the
feat/webpack-to-vite
branch
from
1024f74 to
d8c1df5
Compare
|
@benpsnyder I have looked at the PR, adding tailwindcss is something we avoided to do, for several reasons but the main reason because Blueprintjs is our primary library components and BP does not support tailwindcss styling, we wanna follow the same styling approach of Blueprintjs to add consistency in our project. in the beginning we followed the styled components but now the CSS Module is used. but the PR has a lot can benefit of it, for instance replacing "class=" to "className" becuase as you know className is more for React and we'd like to replace it on the whole project. |
|
@abouolia I will remove the tailwindcss part of this PR so you can complete it. I disagree with not putting tailwindcss into the project but we can take up a discussion about that another time. At the end of the day I think it is valuable to keep momentum of closing PRs that add incremental value to the project. |
benpsnyder
changed the title
Least amount of work possible to get
webapprunning with Vite.Did minimal changes from #399