Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the engine option #207

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Remove the engine option #207

merged 2 commits into from
Jun 9, 2021

Conversation

bholloway
Copy link
Owner

testing

  • unit tests macos
  • unit tests window
  • e2e tests macos
  • e2e tests windows

@bholloway bholloway self-assigned this Jun 9, 2021
@bholloway bholloway changed the title remove the engine option harder, ensure deprecation warning is tested remove the engine option Jun 9, 2021
@bholloway bholloway changed the title remove the engine option Remove the engine option Jun 9, 2021
@bholloway bholloway merged commit 23f7713 into v5 Jun 9, 2021
@bholloway bholloway deleted the remove-engine-option branch June 9, 2021 23:15
@bholloway bholloway added this to the v5 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholloway bholloway

Labels
None yet
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.
1 participant
@bholloway