Merge pull request #207 from bholloway/remove-engine-option

Remove the engine option
bholloway · Jun 9, 2021 · 23f7713 · 23f7713
2 parents 08e153c + 514cefb
commit 23f7713
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 2 deletions.
diff --git a/packages/resolve-url-loader/index.js b/packages/resolve-url-loader/index.js
@@ -20,7 +20,7 @@ const logToTestHarness = require('./lib/log-to-test-harness');
 const DEPRECATED_OPTIONS = {
   engine: [
     'DEP_RESOLVE_URL_LOADER_OPTION_ENGINE',
-    'the "engine" option has been removed, "postcss" is the only available parser'
+    '"engine" option has been removed, postcss is the only parser used'
   ],
   keepQuery: [
     'DEP_RESOLVE_URL_LOADER_OPTION_KEEP_QUERY',

diff --git a/packages/test-my-cli/operations/exec.js b/packages/test-my-cli/operations/exec.js
@@ -100,7 +100,7 @@ exports.create = (command) => {
           addOrRemove(false);
           resolve({
             index, root, caller, cwd, env, meta, code, stdout,
-            stderr: caughtError ? caughtError.toString() : stderr
+            stderr: [ stderr, caughtError ].filter(Boolean).map(String).join('\n')
           });
         }
       })

diff --git a/test/cases/misconfiguration.js b/test/cases/misconfiguration.js
@@ -53,6 +53,36 @@ module.exports = test(
     env({
       ENTRY: join('src', 'index.scss')
     }),
+    testWithOption({ engine: 'postcss' })(
+      testDefault(
+        buildDevNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertDeprecationWarning('"engine" option has been removed'),
+          assertContentDev
+        ),
+        buildProdNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertDeprecationWarning('"engine" option has been removed'),
+          assertContentProd
+        )
+      ),
+      testSilent(
+        buildDevNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertSilence,
+          assertContentDev
+        ),
+        buildProdNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertSilence,
+          assertContentProd
+        )
+      )
+    ),
     testWithOption({ attempts: 1 })(
       testDefault(
         buildDevNormal(