merge #1132
Merged
merge #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
bghira
commented
Nov 10, 2024
bghira
commented
- WSL dockerfile updates
- skip layer guidance for SD3.5 Medium
- multi-caption crash fixes
- validation crash fixes
- validation torch compile fixed
- sd3 uses uniform sampling
- flux schedule shift defaults to 3
Fix missing docker dependencies
…aption-parquets Fix multi-caption parquets crashing in multiple locations (Closes #1092)
sd3: add skip layer guidance
sd3: model card detail expansion
…mpling flux and sd3 could use uniform sampling instead of beta or sigmoid
…dom validation errors with SD3.5 after commit 48cfc09 removed some earlier fixes. This also fixes torch.compile not getting called for the validation pipeline. Calling self.pipeline.to(self.inference_device) appears to have an unwanted side-effect: it moves additional text encoders to the accelerator device. In the case of SD3.5, I saw text_encoder_2 and text_encoder_3 getting moved to the GPU. This caused my RTX 3090 to go OOM when trying to generate validation images during training. Explicitly setting text_encoder_2 and text_encoder_3 to None in extra_pipeline_kwargs fixes this issue.
…-good Fix random validation errors for good (and restore torch.compile for the validation pipeline at the same time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.