Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing docker dependencies #1126

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Fix missing docker dependencies #1126

merged 8 commits into from
Nov 7, 2024

Conversation

Putzzmunta
Copy link

No description provided.

@bghira
Copy link
Owner

bghira commented Nov 7, 2024

this commit is labeled 'add WSL support' - does this inherently resolve the issues of running on Windows? if so, could you add a couple pointers on getting users started in INSTALL.md just under the "Installation" header to help some Windows users get a head start?

@Putzzmunta
Copy link
Author

Putzzmunta commented Nov 7, 2024

I only tested it with docker being installed within an ubuntu wsl2 distro. Therefore, I can't make a call if it is running on windows out of the box.
I will add a section in the docker guide, also explaining on how to setup a docker compose file.

INSTALL.md Outdated Show resolved Hide resolved
documentation/DOCKER.md Outdated Show resolved Hide resolved
documentation/DOCKER.md Outdated Show resolved Hide resolved
documentation/DOCKER.md Outdated Show resolved Hide resolved
documentation/DOCKER.md Outdated Show resolved Hide resolved
@bghira
Copy link
Owner

bghira commented Nov 7, 2024

thanks muchly. i have updated the documentation ( i hope you did not mind ) and will merge this now.

@bghira bghira merged commit fff93bd into bghira:main Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants