Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/rfc: Remove pair declare description for GSP-729 #735

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

JinnyYi
Copy link
Contributor

@JinnyYi JinnyYi commented Sep 2, 2021

We need to declare all the pairs for StorageHTTPSigner operations for now, otherwise, services.PairUnsupportedError will be returned.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #735 (74ee923) into master (ba30a03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   12.47%   12.47%           
=======================================
  Files          22       22           
  Lines        1483     1483           
=======================================
  Hits          185      185           
  Misses       1291     1291           
  Partials        7        7           
Flag Coverage Δ
unittests 12.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba30a03...74ee923. Read the comment docs.

@Xuanwo Xuanwo merged commit 425b81f into master Sep 2, 2021
@Xuanwo Xuanwo deleted the gsp-729 branch September 2, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants