definitions: Deprecate Reacher and expire (#734)

* definitions: Deprecate Reacher * Deprecate expire * fix check error
beyondstorage · Sep 2, 2021 · ba30a03 · ba30a03
1 parent 56d461e
commit ba30a03
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 13 deletions.
diff --git a/cmd/definitions/bindata/bindata.go b/cmd/definitions/bindata/bindata.go
diff --git a/definitions/operations.toml b/definitions/operations.toml
@@ -171,12 +171,20 @@ results = ["n"]
 object_mode = "page"
 
 [reacher]
-description = "is the interface for Reach."
+description = """
+is the interface for Reach.
+
+Deprecated: Use StorageHTTPSigner instead.
+"""
 
 [reacher.op.reach]
-description = "will provide a way, which can reach the object."
 params = ["path"]
 results = ["url"]
+description = """
+will provide a way, which can reach the object.
+
+Deprecated: Use QuerySignHTTPRead instead.
+"""
 
 [servicer]
 description = "can maintain multipart storage services."

diff --git a/definitions/pairs.toml b/definitions/pairs.toml
@@ -19,7 +19,11 @@ description = "specify how to provide endpoint for service or storage"
 
 [expire]
 type = "time.Duration"
-description = "specify when the url returned by reach will expire"
+description = """
+specify when the url returned by reach will expire.
+
+Deprecated: Use `QuerySignHTTPRead` instead of `Reach` and `expire` is the declared argument.
+"""
 
 [interceptor]
 type = "Interceptor"

diff --git a/pairs/generated.go b/pairs/generated.go
diff --git a/tests/connstr_test.go b/tests/connstr_test.go
@@ -3,7 +3,6 @@ package tests
 import (
 	"errors"
 	"testing"
-	"time"
 
 	"github.com/beyondstorage/go-storage/v4/pairs"
 	"github.com/beyondstorage/go-storage/v4/services"
@@ -74,12 +73,11 @@ func TestFromString(t *testing.T) {
 		},
 		{
 			"full format",
-			"tests://abc/tmp/tmp1?size=200&expire=100&storage_class=sc",
+			"tests://abc/tmp/tmp1?size=200&storage_class=sc",
 			[]Pair{
 				pairs.WithName("abc"),
 				pairs.WithWorkDir("/tmp/tmp1"),
 				pairs.WithSize(200),
-				pairs.WithExpire(time.Duration(100)),
 				WithStorageClass("sc"),
 			},
 			nil,

diff --git a/tests/generated.go b/tests/generated.go
diff --git a/types/operation.generated.go b/types/operation.generated.go
@@ -509,11 +509,17 @@ func (s UnimplementedPager) WritePageWithContext(ctx context.Context, o *Object,
 }
 
 // Reacher is the interface for Reach.
+//
+// Deprecated: Use StorageHTTPSigner instead.
 type Reacher interface {
 
 	// Reach will provide a way, which can reach the object.
+	//
+	// Deprecated: Use QuerySignHTTPRead instead.
 	Reach(path string, pairs ...Pair) (url string, err error)
 	// ReachWithContext will provide a way, which can reach the object.
+	//
+	// Deprecated: Use QuerySignHTTPRead instead.
 	ReachWithContext(ctx context.Context, path string, pairs ...Pair) (url string, err error)
 
 	mustEmbedUnimplementedReacher()