-
Notifications
You must be signed in to change notification settings - Fork 55
naga 28 update #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
naga 28 update #132
Conversation
|
oh actually, I'm going to back up a bit and just get |
|
wgsl directive support was added in #123 and actually works for the ray queries, as long as the This seems like a pattern solari actually uses at the moment, so I'm not modifying the test to make it pass, but #123 mentions that trying to make this work got complicated. Other than that (and no actual implementation for mesh shaders) this seems like the v28 upgrade completed. |
|
I was able to fix the rayquery test. for composable modules, the If it is not, the error will indicate that the extension is not enabled. called |
…uery extension, so solari can continue to work
This is a working naga 28 update. I noticed some tests haven't passed (specifically cargo test --all-features) since before 0.14, so this PR doesn't attempt to make them pass.
enumerate_adaptors
instance.enumerate_adaptersis async now (and available on webgpu): gfx-rs/wgpu#8230 . more details in the wgpu release notes.ControlBarrier & MemoryBarrier
Barrier was split in two to support MemoryBarriers: gfx-rs/wgpu#7630
From the PR, it seems like falling back to ControlBarrier is fine so that's what I did.
Ray Query enable
ray queries require
enable wgpu_ray_query;: gfx-rs/wgpu#8545This doesn't currently seem to make it through, and the relevant test fails.
ImageAtomic
Image atomics were added in gfx-rs/wgpu#6706
Mesh Shaders
Mesh shaders are a major feature of wgpu 28,
but I've set their fields to None here in the interest of doing an upgrade and not a feature add at the same timehttps://github.com/gfx-rs/wgpu/releases/tag/v28.0.0
update: I found some time and built a wgpu mesh/task shader demo and used that to validate some of the mesh shader functionality. I've used this to successfully compile a task shader with naga-oil and run it, but there's still something missing from the mesh shader module output here.