Add support for wgsl directives.#123
Merged
robtfm merged 8 commits intobevyengine:masterfrom Jun 23, 2025
Merged
Conversation
atlv24
approved these changes
Jun 21, 2025
Elabajaba
approved these changes
Jun 21, 2025
Contributor
Elabajaba
left a comment
Elabajaba
left a comment
There was a problem hiding this comment.
One small nit and it should probably have an integration test (tychedelia#1)
`dual_source_blending` test
Collaborator
|
as discussed, can we please remove the unused merge code, then looks good to go |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started down the path of allowing imports to also be able to define directives that then get merged and validated when composing the final module, but this started to get too complicated and since this is already pretty niche just went with top level modules being able to declare directives. A lot of that is still there though if someone wanted to implement.