Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Read-only system::run_read_only #7558

Closed
alice-i-cecile opened this issue Feb 7, 2023 · 2 comments · Fixed by #8849
Closed

Add Read-only system::run_read_only #7558

alice-i-cecile opened this issue Feb 7, 2023 · 2 comments · Fixed by #8849
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@alice-i-cecile
Copy link
Member 

          Good call! As a potential followup (idk if we actually need this) we could add a `ReadOnlySystem::run_readonly()`  that allows you to safely run the system with an `&World`.

Originally posted by @cart in #7547 (review)

I think this would be valuable, and should be a very straightforward method to implement. Look at how System's method works for reference.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Design-Doc This issue or PR is particularly complex, and needs an approved design doc before it can be merged and removed S-Needs-Design-Doc This issue or PR is particularly complex, and needs an approved design doc before it can be merged labels Feb 7, 2023
@JoJoJet JoJoJet added the S-Blocked This cannot move forward until something else changes label Feb 8, 2023
@JoJoJet
Copy link
Member

JoJoJet commented Feb 8, 2023

I think we should wait until we're done with properly migrating the engine to UnsafeWorldCell. &World is still being used for interior mutability, so it feels a bit odd to also use &World to guarantee immutable access.

@alice-i-cecile alice-i-cecile removed the D-Trivial Nice and easy! A great choice to get started with Bevy label Feb 8, 2023
@JoJoJet JoJoJet removed the S-Blocked This cannot move forward until something else changes label Jun 15, 2023
@JoJoJet
Copy link
Member

JoJoJet commented Jun 15, 2023

This is unblocked by #8833.

@JoJoJet JoJoJet mentioned this issue Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a method to run read-only systems using &World JoJoJet/bevy
2 participants
@alice-i-cecile @JoJoJet