Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dynamic plugin loading to its own crate #415

Closed
cart opened this issue Sep 2, 2020 · 2 comments
Closed

Move dynamic plugin loading to its own crate #415

cart opened this issue Sep 2, 2020 · 2 comments
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@cart
Copy link
Member

cart commented Sep 2, 2020

Currently we are utilizing features to selectively enable/disable dynamic plugin loading code throughout the bevy codebase. @Dispersia had the good idea to move this to a separate crate, which I think should be possible. This would simplify the cargo features and move all of the dynamic plugin loading code to one spot.
@cart cart added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy labels Sep 2, 2020
@cart cart mentioned this issue Sep 2, 2020
Merged
@EthanYidong
Copy link
Contributor

#544
I've moved all the code that requires libloading to a separate crate, but I'm not sure how to test the changes as none of the examples make use of dynamic loading. Could someone help me figure out how to test these changes?

@CleanCut
Copy link
Member

CleanCut commented Oct 8, 2020

I think this can be closed now that #544 has been merged.

@cart cart closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cart @CleanCut @EthanYidong