Fix errors and panics to typical Rust conventions

Author: joshuajbouw

crates/bevy_app/src/plugin_group.rs

@@ -38,7 +38,10 @@ impl PluginGroupBuilder {
             .find(|(_i, ty)| **ty == TypeId::of::<Target>())
             .map(|(i, _)| i)
             .unwrap_or_else(|| {
-                panic!("Plugin does not exist: {}", std::any::type_name::<Target>())
+                panic!(
+                    "Plugin does not exist: {}.",
+                    std::any::type_name::<Target>()
+                )
             });
         self.order.insert(target_index, TypeId::of::<T>());
         self.plugins.insert(
@@ -59,7 +62,10 @@ impl PluginGroupBuilder {
             .find(|(_i, ty)| **ty == TypeId::of::<Target>())
             .map(|(i, _)| i)
             .unwrap_or_else(|| {
-                panic!("Plugin does not exist: {}", std::any::type_name::<Target>())
+                panic!(
+                    "Plugin does not exist: {}.",
+                    std::any::type_name::<Target>()
+                )
             });
         self.order.insert(target_index + 1, TypeId::of::<T>());
         self.plugins.insert(
@@ -76,7 +82,7 @@ impl PluginGroupBuilder {
         let mut plugin_entry = self
             .plugins
             .get_mut(&TypeId::of::<T>())
-            .expect("Cannot enable a plugin that does not exist");
+            .expect("Cannot enable a plugin that does not exist.");
         plugin_entry.enabled = true;
         self
     }
@@ -85,7 +91,7 @@ impl PluginGroupBuilder {
         let mut plugin_entry = self
             .plugins
             .get_mut(&TypeId::of::<T>())
-            .expect("Cannot disable a plugin that does not exist");
+            .expect("Cannot disable a plugin that does not exist.");
         plugin_entry.enabled = false;
         self
     }

crates/bevy_app/src/schedule_runner.rs

@@ -113,7 +113,7 @@ impl Plugin for ScheduleRunnerPlugin {
                                     f.as_ref().unchecked_ref(),
                                     dur.as_millis() as i32,
                                 )
-                                .expect("should register `setTimeout`");
+                                .expect("Should register `setTimeout`.");
                         }
                         let asap = Duration::from_millis(1);
 

crates/bevy_asset/src/asset_server.rs

@@ -16,15 +16,15 @@ use thiserror::Error;
 /// Errors that occur while loading assets with an AssetServer
 #[derive(Error, Debug)]
 pub enum AssetServerError {
-    #[error("Asset folder path is not a directory.")]
+    #[error("asset folder path is not a directory")]
     AssetFolderNotADirectory(String),
-    #[error("No AssetLoader found for the given extension.")]
+    #[error("no AssetLoader found for the given extension")]
     MissingAssetLoader(Option<String>),
-    #[error("The given type does not match the type of the loaded asset.")]
+    #[error("the given type does not match the type of the loaded asset")]
     IncorrectHandleType,
-    #[error("Encountered an error while loading an asset.")]
+    #[error("encountered an error while loading an asset")]
     AssetLoaderError(anyhow::Error),
-    #[error("PathLoader encountered an error")]
+    #[error("`PathLoader` encountered an error")]
     PathLoaderError(#[from] AssetIoError),
 }
 
@@ -238,7 +238,7 @@ impl AssetServer {
         let mut asset_sources = self.server.asset_sources.write();
         let source_info = asset_sources
             .get_mut(&asset_path_id.source_path_id())
-            .expect("AssetSource should exist at this point");
+            .expect("`AssetSource` should exist at this point.");
         if version != source_info.version {
             return Ok(asset_path_id);
         }
@@ -317,7 +317,7 @@ impl AssetServer {
                     continue;
                 }
                 let handle =
-                    self.load_untyped(child_path.to_str().expect("Path should be a valid string"));
+                    self.load_untyped(child_path.to_str().expect("Path should be a valid string."));
                 handles.push(handle);
             }
         }
@@ -334,7 +334,7 @@ impl AssetServer {
             let ref_change = match receiver.try_recv() {
                 Ok(ref_change) => ref_change,
                 Err(TryRecvError::Empty) => break,
-                Err(TryRecvError::Disconnected) => panic!("RefChange channel disconnected"),
+                Err(TryRecvError::Disconnected) => panic!("RefChange channel disconnected."),
             };
             match ref_change {
                 RefChange::Increment(handle_id) => *ref_counts.entry(handle_id).or_insert(0) += 1,
@@ -377,7 +377,7 @@ impl AssetServer {
             let asset_value = asset
                 .value
                 .take()
-                .expect("Asset should exist at this point");
+                .expect("Asset should exist at this point.");
             if let Some(asset_lifecycle) = asset_lifecycles.get(&asset_value.type_uuid()) {
                 let asset_path =
                     AssetPath::new_ref(&load_context.path, label.as_ref().map(|l| l.as_str()));
@@ -431,7 +431,7 @@ impl AssetServer {
                 Err(TryRecvError::Empty) => {
                     break;
                 }
-                Err(TryRecvError::Disconnected) => panic!("AssetChannel disconnected"),
+                Err(TryRecvError::Disconnected) => panic!("AssetChannel disconnected."),
             }
         }
     }

crates/bevy_asset/src/filesystem_watcher.rs

@@ -12,9 +12,9 @@ impl Default for FilesystemWatcher {
     fn default() -> Self {
         let (sender, receiver) = crossbeam_channel::unbounded();
         let watcher: RecommendedWatcher = Watcher::new_immediate(move |res| {
-            sender.send(res).expect("Watch event send failure");
+            sender.send(res).expect("Watch event send failure.");
         })
-        .expect("Failed to create filesystem watcher");
+        .expect("Failed to create filesystem watcher.");
         FilesystemWatcher { watcher, receiver }
     }
 }

crates/bevy_asset/src/handle.rs

@@ -274,7 +274,7 @@ impl HandleUntyped {
     pub fn typed<T: Asset>(mut self) -> Handle<T> {
         if let HandleId::Id(type_uuid, _) = self.id {
             if T::TYPE_UUID != type_uuid {
-                panic!("attempted to convert handle to invalid type");
+                panic!("Attempted to convert handle to invalid type.");
             }
         }
         let handle_type = match &self.handle_type {

crates/bevy_asset/src/io/file_asset_io.rs

@@ -122,7 +122,7 @@ pub fn filesystem_watcher_system(asset_server: Res<AssetServer>) {
             let event = match watcher.receiver.try_recv() {
                 Ok(result) => result.unwrap(),
                 Err(TryRecvError::Empty) => break,
-                Err(TryRecvError::Disconnected) => panic!("FilesystemWatcher disconnected"),
+                Err(TryRecvError::Disconnected) => panic!("FilesystemWatcher disconnected."),
             };
             if let notify::event::Event {
                 kind: notify::event::EventKind::Modify(_),

crates/bevy_asset/src/io/mod.rs

@@ -24,11 +24,11 @@ use thiserror::Error;
 /// Errors that occur while loading assets
 #[derive(Error, Debug)]
 pub enum AssetIoError {
-    #[error("Path not found")]
+    #[error("path not found")]
     NotFound(PathBuf),
-    #[error("Encountered an io error while loading asset.")]
+    #[error("encountered an io error while loading asset")]
     Io(#[from] io::Error),
-    #[error("Failed to watch path")]
+    #[error("failed to watch path")]
     PathWatchError(PathBuf),
 }
 

crates/bevy_asset/src/lib.rs

@@ -55,7 +55,7 @@ impl Plugin for AssetPlugin {
         let task_pool = app
             .resources()
             .get::<IoTaskPool>()
-            .expect("IoTaskPool resource not found")
+            .expect("`IoTaskPool` resource not found.")
             .0
             .clone();
 

crates/bevy_asset/src/loader.rs

@@ -152,7 +152,10 @@ impl<T: AssetDynamic> AssetLifecycle for AssetLifecycleChannel<T> {
                 }))
                 .unwrap()
         } else {
-            panic!("failed to downcast asset to {}", std::any::type_name::<T>());
+            panic!(
+                "Failed to downcast asset to {}.",
+                std::any::type_name::<T>()
+            );
         }
     }
 

crates/bevy_asset/src/path.rs

@@ -143,7 +143,7 @@ impl<'a, 'b> From<&'a AssetPath<'b>> for AssetPathId {
 impl<'a> From<&'a str> for AssetPath<'a> {
     fn from(asset_path: &'a str) -> Self {
         let mut parts = asset_path.split('#');
-        let path = Path::new(parts.next().expect("path must be set"));
+        let path = Path::new(parts.next().expect("Path must be set."));
         let label = parts.next();
         AssetPath {
             path: Cow::Borrowed(path),