Skip to content

Conversation

@doup
Copy link
Contributor

@doup doup commented Apr 1, 2022

UX changes:

  • Improved responsive header, call-to-actions are visible on all breakpoints
  • Header is fixed, it always stays on top
  • Improved mobile menu, it joins both the main menu & page menu (book, assets & examples). When there isn't a page level menu it shows just the main menu.
    • ⚠️ Please note that I haven't changed the style of the page menus on mobile, they're too small and should be improved. But that's for another PR.
  • Page level sidebar menus now are sticky, user has access to the page menu always

Code changes:

  • Self contained CSS "components" following BEM naming convention
  • New "page-with-menu" layout added

Fixes #135, Fixes #307

bevy-improved-header.mp4

@doup doup changed the title Improve header navigation Improve header navigation & homepage feature rows Apr 2, 2022
…improve-header

# Conflicts:
#	templates/index.html
@doup doup marked this pull request as ready for review April 2, 2022 16:54
@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site C-Webdev labels Apr 2, 2022
@CooCooCaCha
Copy link
Contributor

I'm encountering a strange issue when I use Chrome DevTools or Firefox Devtools. When the screen is narrow the page appears to extend past the width of the screen. I think it might be due to an issue with position: fixed.

bevy_header_issue

doup added 2 commits April 16, 2022 19:56
…improve-header

# Conflicts:
#	sass/_mixins.scss
#	sass/site.scss
@IceSentry
Copy link
Contributor

Alright, there's still the book menu that gets hidden by the nav bar when you scroll all the way down, but it's not a super big deal. Other than that I haven't noticed anything wrong visually. I'll do a final pass on the code before approving.

Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doup
Copy link
Contributor Author

doup commented Apr 22, 2022

I think that there isn't much to do with the menu, it's how position: sticky behaves. See for example Procreates manual: https://procreate.art/handbook/procreate/interface-gestures/ once you reach the footer it happens the same.

You mentioned position: absolute in another message, I can give it a try, but I've the impression that getting the left position might be tricky/ugly…

Btw, I noticed I forgot to add the "section title" part on the header… I need to add it back. 😓
This 👇
image

@doup
Copy link
Contributor Author

doup commented Apr 22, 2022

OK, fixed:
image

@IceSentry
Copy link
Contributor

IceSentry commented Apr 23, 2022

Oh, good catch with the section title, I was so focused on everything else when testing it I didn't even realize it was gone 😅

And yeah, for the menu thing it's not a big issue. I prefer the cleaner, simpler approach that isn't perfect in all cases instead of making something super hacky.

Seeing, your link to procreate.art now reminds me that it would be cool if we had a night/day mode switch. I love my dark themes, but plenty of people prefer light themes.

@cart
Copy link
Member

cart commented May 4, 2022

I dig the changes functionally. Just a few changes to address:

  1. The text sections now "bleed out" of the bounds of their corresponding images and also feel "off center" now.
  2. The text on the donate button feels "too high" now
  3. I'd like the "Features" text to be slightly bigger and bolder
  4. I think the navigation text should all be a bit bolder.

Left is "before" (current main). Right is "after" (this pr).

image

@doup
Copy link
Contributor Author

doup commented Jun 20, 2022

I've fixed all the issues you pointed out @cart.

For the first one (the feature page layout) I've just made it similar to what's now on production, and I've also improved responsive. It's not very good, but at least it doesn't break on mobile/tablet… The homepage needs some love, but that's for another PR.

@cart
Copy link
Member

cart commented Jun 21, 2022

Love the changes. The potential for "feature image background aspect ratio" changes when scaling the width down is slightly regrettable, but the improved use of space during scaling feels like a worthwhile trade to me.

Great work!

@cart
Copy link
Member

cart commented Jun 21, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jun 21, 2022
**UX changes:**
- Improved responsive header, call-to-actions are visible on all breakpoints
- Header is fixed, it always stays on top
- Improved mobile menu, it joins both the main menu & page menu (book, assets & examples). When there isn't a page level menu it shows just the main menu.
  - ⚠️ Please note that I haven't changed the style of the page menus on mobile, they're too small and should be improved. **But that's for another PR**.
- Page level sidebar menus now are sticky, user has access to the page menu always

**Code changes:**
- Self contained CSS "components" following BEM naming convention
- New "page-with-menu" layout added

Fixes #135, Fixes #307

https://user-images.githubusercontent.com/188612/161392786-63110a84-bb56-40af-8914-753a44df9ae1.mp4
@bors
Copy link

bors bot commented Jun 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Improve header navigation [Merged by Bors] - Improve header navigation Jun 21, 2022
@bors bors bot closed this Jun 21, 2022
@doup doup deleted the feature/improve-header branch June 22, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Bug A problem with the code that runs the site C-Webdev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve header responsive design & docs/assets menu integration "Donate" and "Get Started" buttons not visible on mobile

5 participants