Skip to content

support angle_controller debug #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

support angle_controller debug #620

wants to merge 1 commit into from

Conversation

@ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Dec 10, 2022 •
edited by haslinghuis
Loading

Support for the new ANGLE_CONTROLLER debug from @ChrisRosser.

This is for testing purposes only, at this time.

See firmware PR #12041.

EDIT: #12231.

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 10, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

sugaarK
sugaarK previously approved these changes Dec 10, 2022
View reviewed changes
@haslinghuis haslinghuis added this to the 3.7.0 milestone Dec 10, 2022
haslinghuis
haslinghuis requested changes Dec 10, 2022
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

@haslinghuis haslinghuis modified the milestones: 3.7.0, 3.8.0 Dec 11, 2022
@ctzsnooze ctzsnooze force-pushed the support-ANGLE_CONTROLLER-debug branch from ccdad66 to ea36b0b Compare December 20, 2022 05:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 20, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
5.8% 5.8% Duplication

@github-actions

This comment has been minimized.

Sign in to view
@ctzsnooze ctzsnooze force-pushed the support-ANGLE_CONTROLLER-debug branch from ea36b0b to 88a6f63 Compare July 15, 2023 06:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@haslinghuis
Copy link
Member

haslinghuis commented Dec 3, 2023

Superseded by #674

@haslinghuis haslinghuis closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis requested changes

@nerdCopter nerdCopter nerdCopter approved these changes

@sugaarK sugaarK sugaarK left review comments

Assignees

@ctzsnooze ctzsnooze

Labels

Do Not Merge needs coordination with betaflight rebase required RN: IMPROVEMENT Work in progress

Projects

Finalizing Firmware 4.5 Release
Status: COMPLETED

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ctzsnooze @blckmn @haslinghuis @nerdCopter @sugaarK