Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flexview capability and colored pointcloud #32

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

Solrac3589
Copy link

This PR depends on beta-robots/common_msgs#1 to work.

colored option it is half done but not finished (there is no RGB ensenso yet).

@carlosjoserg
Copy link
Member

In general seems ok.

I see a lot of debug prints though, like https://github.com/beta-robots/ensenso_nx/pull/32/files#diff-c543d1f9da91fbe1d6f262ce45837424R212

At least, you might want to wrap them in a macro like:

#ifdef VERBOSE
#define DEBUG_PRINTOUT( m ) std::cout << m
#else
#define DEBUG_PRINTOUT( m )
#endif

And then use it like:

DEBUG_PRINTOUT("inside grab grayscale capturing" << std::endl);

So only when #define VERBOSE is present you will have debug prints.

/cc @andreucm

@andreucm
Copy link
Member

andreucm commented Apr 7, 2020

yes, adding a VERBOSE def is necessary. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants