Skip to content

Stop all sub processes spawn by acceptance tests#8284

Merged
macfarla merged 2 commits intobesu-eth:mainfrom
fab-10:retry-8226-stop-besu-subprocess-in-ats
Feb 13, 2025
Merged

Stop all sub processes spawn by acceptance tests#8284
macfarla merged 2 commits intobesu-eth:mainfrom
fab-10:retry-8226-stop-besu-subprocess-in-ats

Conversation

@fab-10
Copy link
Copy Markdown
Contributor

@fab-10 fab-10 commented Feb 12, 2025

PR description

Another attempt to release this fix after #8226 has been reverted here #8236, this time reducing the memory used by Gradle

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the retry-8226-stop-besu-subprocess-in-ats branch from 5689b42 to 1f98ebf Compare February 13, 2025 09:59
@fab-10 fab-10 marked this pull request as ready for review February 13, 2025 10:35
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla merged commit 46e74d1 into besu-eth:main Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants