Stop all sub processes spawn by acceptance tests#8226
Merged
fab-10 merged 3 commits intobesu-eth:mainfrom Feb 3, 2025
Merged
Conversation
fab-10
force-pushed
the
stop-besu-subprocess-in-ats
branch
from
8d7b28b to
87e282b
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
stop-besu-subprocess-in-ats
branch
from
87e282b to
4a28100
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
stop-besu-subprocess-in-ats
branch
from
4a28100 to
b21502c
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
macfarla
approved these changes
Feb 3, 2025
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
Feb 4, 2025
…)" This reverts commit d691f45. Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
macfarla
added a commit
that referenced
this pull request
Feb 4, 2025
This reverts commit d691f45. Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
* Stop all sub processes spawn by acceptance tests Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Split long running test in 3 parts Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Run ATs sequentially Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This was referenced Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Re-attempt to fixing flaky ATs by correctly stopping all Besu sub-processes spawn by each ATs, and clearing all they resources.
Since this with this change the
BftMiningAcceptanceTestAT takes ~27 mins on CI, it has been split in 3 parts so they can run in parallel and takes around 10 mins each.ATs are also run sequentially to avoid resources exhaustion due to too many running Besu sub-processes.
Fixed Issue(s)
fixes #7596
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests