Add support for movePrecompileToAddress in State Overrides (eth_call)#8115
Merged
Gabriel-Trintinalia merged 17 commits intobesu-eth:mainfrom Jan 15, 2025
Merged
Conversation
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Gabriel-Trintinalia
added
the
doc-change-required
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…el-Trintinalia/besu into move-precompile-to-address
macfarla
reviewed
Jan 14, 2025
| "movePrecompileToAddress":null | ||
| "0x0000000000000000000000000000000000000001": { | ||
| "comment" : "Move ECREC Precompiled to address", | ||
| "movePrecompileToAddress": "0xc000000000000000000000000000000000000001" |
Contributor
There was a problem hiding this comment.
maybe we also need a test that moves the precompile AND changes the code?
Contributor
There was a problem hiding this comment.
wait, what is this testing, if the address and the movePrecompileToAddress are the same?
Contributor
Author
There was a problem hiding this comment.
This tests if the original behaviour of the precompile can be called at the new address
Contributor
Author
There was a problem hiding this comment.
maybe we also need a test that moves the precompile AND changes the code?
Done
8 tasks
jframe
reviewed
Jan 14, 2025
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
macfarla
approved these changes
Jan 15, 2025
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
looking pretty good, few nitpicking comments
| "params": [ | ||
| { | ||
| "from": "0xc100000000000000000000000000000000000000", | ||
| "comment": "Call to precompile ECREC (0x01), but code was modified to add 1 to input", |
…saction/SimulationTransactionProcessorFactoryTest.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…sonrpc/internal/methods/EthCallTest.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…sonrpc/internal/methods/EthCallTest.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…el-Trintinalia/besu into move-precompile-to-address
siladu
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Jan 16, 2025
…besu-eth#8115) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
alexandratran
removed
the
doc-change-required
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…besu-eth#8115) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the
movePrecompileToAddressfeature in theStateOverridesfor methods associated withTransaction Call Objectand refactors theMainnetTransactionProcessorclass to use a builder pattern. Additionally, it includes updates to the associated test cases and JSON-RPC resources to accommodate these changes.fixes: #8031
Changes
movePrecompileToAddressSupportMainnetTransactionProcessorBuilder Pattern