feat: Added implementation support for movePrecompileToAddress#8086
Closed
pr9t wants to merge 1 commit intobesu-eth:mainfrom
Closed
feat: Added implementation support for movePrecompileToAddress#8086pr9t wants to merge 1 commit intobesu-eth:mainfrom
pr9t wants to merge 1 commit intobesu-eth:mainfrom
Conversation
Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
Contributor
Contributor
Author
|
Hey @macfarla, to use the value in the simulation, do I need to add it to this code? protected void applyOverrides(final MutableAccount account, final AccountOverride override) {
LOG.debug("applying overrides to state for account {}", account.getAddress());
override.getNonce().ifPresent(account::setNonce);
if (override.getBalance().isPresent()) {
account.setBalance(override.getBalance().get());
}
override.getCode().ifPresent(n -> account.setCode(Bytes.fromHexString(n)));
override
.getStateDiff()
.ifPresent(
d ->
d.forEach(
(key, value) ->
account.setStorageValue(
UInt256.fromHexString(key), UInt256.fromHexString(value))));
} |
Contributor
Kind of - you're definitely on the right track! Have a look at #8115 from @Gabriel-Trintinalia which takes it a bit further. Precompiles are handled a bit differently to other addresses so there's some extra complexity. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
fixes #8031
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests