Skip to content

fix: Fix DNSDaemonTest - remove flaky assertion #7701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 2 commits into from
Oct 1, 2024
Merged

fix: Fix DNSDaemonTest - remove flaky assertion #7701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
634f439
fix: Fix DNSDaemonTest - remove flaky assertion
usmansaleem Oct 1, 2024
83ce603
fix imports
usmansaleem Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ...reum/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/dns/DNSDaemonTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
*/
package org.hyperledger.besu.ethereum.p2p.discovery.dns;

import static org.assertj.core.api.Assertions.assertThat;

import java.security.Security;
import java.util.concurrent.atomic.AtomicInteger;

Expand All @@ -26,7 +24,6 @@
import io.vertx.junit5.VertxExtension;
import io.vertx.junit5.VertxTestContext;
import org.bouncycastle.jce.provider.BouncyCastleProvider;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.DisplayName;
Expand Down Expand Up @@ -136,10 +133,4 @@ void testDNSDaemonPeriodic(final Vertx vertx, final VertxTestContext testContext
.setWorkerPoolSize(1);
vertx.deployVerticle(dnsDaemon, options);
}

@AfterEach
@DisplayName("Check that the vertx worker verticle is still there")
void lastChecks(final Vertx vertx) {
assertThat(vertx.deploymentIDs()).isNotEmpty().hasSize(2);
}
}