Skip to content

fix: Fix DNSDaemonTest - remove flaky assertion#7701

Merged
macfarla merged 2 commits intobesu-eth:mainfrom
usmansaleem:dns_daemon_flaky_test
Oct 1, 2024
Merged

fix: Fix DNSDaemonTest - remove flaky assertion#7701
macfarla merged 2 commits intobesu-eth:mainfrom
usmansaleem:dns_daemon_flaky_test

Conversation

@usmansaleem
Copy link
Copy Markdown
Contributor

PR description

fix: Fix DNSDaemonTest - remove flaky assertion

Fixed Issue(s)

fixes #7690

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem self-assigned this Oct 1, 2024
@usmansaleem usmansaleem requested review from jframe and macfarla October 1, 2024 01:49
Signed-off-by: Usman Saleem <usman@usmans.info>
Copy link
Copy Markdown
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable as we shouldn't need to rely on the vertx worker verticle still being there

Copy link
Copy Markdown
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit d081c17 into besu-eth:main Oct 1, 2024
@usmansaleem usmansaleem deleted the dns_daemon_flaky_test branch January 9, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNSDaemonTest > Test DNS Daemon with a mock DNS server FAILED

4 participants