Allow API configuration to override supplied gasLimit#6978
Merged
garyschulte merged 5 commits intobesu-eth:mainfrom May 1, 2024
Merged
Conversation
macfarla
reviewed
Apr 24, 2024
| LOG.info("Capping gasLimit to " + gasCap); | ||
| } | ||
| gasLimit = rpcGasCap; | ||
| LOG.info("Capping gasLimit to " + rpcGasCap); |
Contributor
There was a problem hiding this comment.
so no longer comparing gasCap to gasLimit, just if > zero?
Contributor
Author
There was a problem hiding this comment.
yes, it is essentially an override value from the cli. @matkt can speak to the specifics about why we would raise the cap beyond the requested limit, but I think it has something to do with simulating transactions that will exceed the anticipated gas, but not exceed some predefined hard cap (DoS vector).
Contributor
There was a problem hiding this comment.
yes it is need in order to allow user setting a high gasLimit for ethcall
| @Test | ||
| public void shouldKeepOriginalGasLimitWhenCapIsHigherThanOriginalValue() { | ||
| // generate a transaction with a gas limit that is lower than the gas cap | ||
| public void shouldUseRpcGasCapWhenCapIsHigherThanGasLimit() { |
Contributor
There was a problem hiding this comment.
what if cap is lower than gasLimit
Contributor
Author
There was a problem hiding this comment.
yeah, this test can really just be renamed to something like "when present rpc gas cap supersedes request gas limit"
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/configurable-simulation-tx-gas-limit
branch
from
f40d66c to
c3e9cf3
Compare
garyschulte
added
the
doc-change-required
alexandratran
removed
the
doc-change-required
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
* allow gasLimit configuration for transaction simulation * revise unit test to reflect new behavior of rpcGasCap Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* allow gasLimit configuration for transaction simulation * revise unit test to reflect new behavior of rpcGasCap Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
* allow gasLimit configuration for transaction simulation * revise unit test to reflect new behavior of rpcGasCap Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Allow API configuration to override supplied gasLimit. Originally this commit was part of #6641. Moved here for visibility and easier review.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests