Skip to content

Feature/fleet mode rebase#6641

Merged
garyschulte merged 5 commits intobesu-eth:mainfrom
garyschulte:feature/fleet-mode-rebase
May 22, 2024
Merged

Feature/fleet mode rebase#6641
garyschulte merged 5 commits intobesu-eth:mainfrom
garyschulte:feature/fleet-mode-rebase

Conversation

@garyschulte
Copy link
Copy Markdown
Contributor

@garyschulte garyschulte commented Feb 28, 2024

PR description

rebase onto main of the services refactor for fleet mode, see original #6003

Fixed Issue(s)

@garyschulte garyschulte marked this pull request as ready for review March 1, 2024 01:09
@garyschulte garyschulte force-pushed the feature/fleet-mode-rebase branch 2 times, most recently from b6689c9 to 87104d6 Compare March 1, 2024 01:16
Copy link
Copy Markdown
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we tried follower+leader with this last commit ?

@matkt
Copy link
Copy Markdown
Contributor

matkt commented Mar 1, 2024

@jframe could you check the block pruning modification we are doing in this PR to be sure it's correct. normally we did tests but I prefer to have your feedback

@garyschulte
Copy link
Copy Markdown
Contributor Author

garyschulte commented Mar 1, 2024

@jframe could you check the block pruning modification we are doing in this PR to be sure it's correct. normally we did tests but I prefer to have your feedback

I inadvertentlty tested this feature on the captain of a captain-follower sepolia pair, and block pruning is definitely working.

did we tried follower+leader with this last commit ?

I am resyncing the follower now to ensure it works correctly, since it failed to find the pruned captain blocks on the prior test 😂

@garyschulte garyschulte force-pushed the feature/fleet-mode-rebase branch from f36ba49 to 6a87c5c Compare March 1, 2024 14:37
@garyschulte
Copy link
Copy Markdown
Contributor Author

did we tried follower+leader with this last commit ?

Yes, confirmed the follower syncs and follows with only a leader.

Regarding the pruner on the follower, I see it configured, but I am not seeing any executions of the pruner triggered.

@jframe
Copy link
Copy Markdown
Contributor

jframe commented Mar 4, 2024

@jframe could you check the block pruning modification we are doing in this PR to be sure it's correct. normally we did tests but I prefer to have your feedback

Is the changes in the ChainDataPruner to only start pruning after the initial sync? Think it's better not to delay this until after the initial sync to keep the storage used small. Ideally, you would have Besu configured with --Xcheckpoint-post-merge-enabled so there isn't anything to prune anyway. Probably need to think more about how these and sync all interact.

@garyschulte garyschulte force-pushed the feature/fleet-mode-rebase branch 3 times, most recently from e4c8b4a to 9a279ec Compare March 9, 2024 00:53
@garyschulte garyschulte force-pushed the feature/fleet-mode-rebase branch 2 times, most recently from 465042a to 4fb1a3a Compare April 16, 2024 20:11
@garyschulte garyschulte force-pushed the feature/fleet-mode-rebase branch 2 times, most recently from 3f4e197 to 8836bfb Compare April 22, 2024 19:26
Copy link
Copy Markdown
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we had time to do a quick test with the fleet plugin I think we can merge this PR

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the feature/fleet-mode-rebase branch from d514f70 to 1b2443d Compare May 22, 2024 16:29
@garyschulte garyschulte enabled auto-merge (squash) May 22, 2024 16:37
@garyschulte garyschulte merged commit ebb8830 into besu-eth:main May 22, 2024
@non-fungible-nelson
Copy link
Copy Markdown
Contributor

🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢

jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
* fleet mode squash commit rebase

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jframe jframe mentioned this pull request Jun 10, 2024
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
* fleet mode squash commit rebase

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants