Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #7 don't intercept key events sent to editable inputs #8

Closed
wants to merge 2 commits into from

Conversation

mojavelinux
Copy link
Contributor

No description provided.

@mojavelinux
Copy link
Contributor Author

I had to make a change to how simulant is loaded in order to get the tests to run. However, I didn't include that change as part of this PR as I'm unsure whether it's just my setup that is messed up.

Here's what I had to add:

var simulant = require('simulant')

Two changes:

  1. Require "simulant" instead of "simulant/simulant"
  2. Assign the return result to the variable "simulant"

@mojavelinux
Copy link
Contributor Author

Yep, it appears like this fails on Travis too, so I'll go ahead and include the change to the test suite.

@mojavelinux
Copy link
Contributor Author

We're passing in Travis now \o/

@mojavelinux
Copy link
Contributor Author

Wow, I feel like such a moron. I just figured out that this is the whole point of the bespoke-forms plugin. For some reason, I got the impression that bespoke-forms was disabling form inputs. Now that I realize it's preventing the key strokes from triggering navigation, it all makes sense.

I still need to salvage the fixes to the test suites. I'd prepare a separate PR then close this one when it's ready.

@mojavelinux
Copy link
Contributor Author

What I might do is attach the fixes to the test suite to #6.

@mojavelinux
Copy link
Contributor Author

PR #6 updated. Withdrawing this pull request.

@mojavelinux mojavelinux deleted the issue-7 branch August 14, 2015 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant