Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't intercept key events sent to editable inputs #7

Closed
mojavelinux opened this issue Aug 11, 2015 · 1 comment
Closed

Don't intercept key events sent to editable inputs #7

mojavelinux opened this issue Aug 11, 2015 · 1 comment

Comments

@mojavelinux
Copy link
Contributor

Don't intercept key events that are being sent to an editable input, such as a text area.

Presenters often like to use editable inputs in the presentation to explain concepts, such as an editable source code block. Currently, it's impossible to type into one of these elements without triggering the slide navigation. The plugin should check to ensure that the element is not an editable input before acting on the key event.
mojavelinux added a commit to mojavelinux/bespoke-keys that referenced this issue Aug 11, 2015
@mojavelinux
resolves bespokejs#7 don't intercept key events sent to editable inputs
d4aa24e
mojavelinux added a commit to mojavelinux/bespoke-keys that referenced this issue Aug 11, 2015
@mojavelinux
resolves bespokejs#7 don't intercept key events sent to editable inputs
cbbaec4
@mojavelinux mojavelinux mentioned this issue Aug 11, 2015
Open
@mojavelinux
Copy link
Contributor Author

As I mentioned in the comment of the PR, I completely missed that this is the point of bespoke-forms. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mojavelinux