Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with estree (specifically, babel-core/acorn) #112

Merged
merged 15 commits into from
Jun 28, 2015

Conversation

tobich
Copy link
Contributor

@tobich tobich commented Apr 30, 2015

Adds definitions of ES6 modules according to the estree standard (as implemented by the babel-core/acorn parser.)

@benjamn
Copy link
Owner

benjamn commented Apr 30, 2015

Just pushed b49b008 to master, which might allow you to rebase and get tests to pass without your latest two commits.

# Conflicts:
#	.travis.yml
@tobich
Copy link
Contributor Author

tobich commented May 3, 2015

"npm install -g npm@'>=1.4.3'" in .travis.yml is still required for the tests to pass (nodejs 0.8)

@ai
Copy link

ai commented May 30, 2015

Any updates? This error makes a problem with Babel and Regenrator babel/babel#1471

.build("local")
.field("local", def("Identifier"));

def("ModuleSource");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used/needed?

@benjamn
Copy link
Owner

benjamn commented May 30, 2015

I plan to merge these defs into https://github.com/benjamn/ast-types/blob/master/def/es6.js the next time I make a breaking version change.

benjamn added a commit that referenced this pull request Jun 28, 2015
Compatibility with estree (specifically, babel-core/acorn).
@benjamn benjamn merged commit f9e1bd3 into benjamn:master Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants