-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 modules and estree compatibility #111
Comments
Please go ahead and submit a pull request for the babel-core/acorn version of the AST, and we'll figure out a way to let users choose which version to use (see #57). For clarity, you might be able to put the modified definitions in their own file, so that they just override the old definitions when the new file is evaluated. Thanks a ton @tobich! |
I am trying to get the pull request through, but the CI seems to be using really ancient npm version, it cannot install babel-core. :-( |
Fixed by 0f3f363, hopefully! |
@benjamn Following the esprima-fb's planned deprecation, I've put together forks of ast-types and recast which work with babel-core/acorn as parser instead. The biggest issue seems to be the incompatibility of Export and Import specifiers in esprima-fb vs estree/acorn/everybody else. As far as I understand, both definition sets cannot be included at the same time (several type names overlap). In case you are interested in pull request – what approach do you suggest? Abandoning esprima-fb altogether, or some kind of configuration/multiple main.js/other?
The text was updated successfully, but these errors were encountered: