Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-cookie): Add CookieGetOptions to useCookies #532

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

presto2116
Copy link
Contributor

@presto2116 presto2116 commented May 10, 2024

Creating PR to add options to useCookies. This will allow users to overwrite doNotUpdate and doNotParse options.

This is needed as we, like others, are running into the issue that large integers are getting incorrectly parsed.

#448 & #386

@presto2116
Copy link
Contributor Author

@eXon When you get a chance can you please review this PR. thank you

@presto2116
Copy link
Contributor Author

@eXon Checking in on this. Are you able to review? this would be very helpful for our use case and seeing others having similar issues, it seems like it could help everyone. thanks.

Copy link
Collaborator

@eXon eXon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a fair use, we can move forward with that once you add the missing option in the documentation. 👍

packages/react-cookie/README.md Show resolved Hide resolved
@eXon eXon force-pushed the feat/react-cookies-get-options branch from defbe26 to f3e90da Compare July 21, 2024 14:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants