add goroutine #21
Open
add goroutine #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is it parallelized? Are you having performance issues with it? |
|
I felt slow on Windows machine only yet... However, it will have effect on Mac, Linux. |
|
Do you have timing numbers for serial vs parallel on Windows? Also, I'm a little worried about leaving it unbounded. If you run that against a large set of templates on a relatively weaker box then it could OOM the process. |
|
No I don't have exactly, because I will try this on Linux jenkins machine. If you have consideration, I will close this issue, or will give a flag to control Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added goroutine, please check it.