add pre-commit configs

[luca-medeiros]

• added pre-commit configs on a followup from previous PR Add ruff linter #83
• added related docs
• ran the pre-commit on all files of main

[luca-medeiros]

Ive just seen the works of #91. @mithun2003 mind doing some review here?

[mithun2003]

Is this pre-commit check for print statements in the code beneficial? It ensures that prints are reviewed before committing changes.

[luca-medeiros]

@mithun2003 seems there are only two print statements in this repo. Not sure print reviews are needed.

[igorbenav]

Maybe we should remove the print statements at once and use proper logging for the worker, checking whether there are print statements would be useful in this case.

By the way, how do you guys feel about moving the worker script from app to core/utils?

[luca-medeiros]

Agree with the proper logging. What about creating a worker folder under core?
app/worker.py -> app/core/worker/settings.py, app/core/worker/functions.py

That much depth maybe too much and redundant for now, but I believe there is room for expansion for arq worker.

[igorbenav]

Yeah, I think it's a good approach. Stuff like dynamic prioritization, scheduling, custom retry would be cool.

[luca-medeiros]

Yeah, lots can be done with workers.

@igorbenav any thoughts about the PR? I thought about creating a separate part on readme to further explain pre-commit to the people who fork the repo. For now, I only added an extra step to the Contributing part.

[igorbenav]

I think it's a good idea, @luca-medeiros. Do you want to add it to this PR or do it in the future? I'll merge it.

[luca-medeiros]

@igorbenav refactored the contributing docs.