Add ruff linter #83
Merged
Add ruff linter #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-medeiros
commented
Dec 28, 2023
|
I could add a pre-commit config as well |
|
Nice one, @luca-medeiros! I'll check if this extra import is necessary in alembic migrations, but I don't think it is since I'm importing Base. No Idea why I created it in the first place |
igorbenav
approved these changes
Dec 31, 2023
|
@luca-medeiros if you'd like to add the pre-commit config, I'd appreciate it a lot |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ruff linter to pyproject with some basic configs after seeing it on the roadmap. I think we could find the best settings for this project later on.
Also ran ruff format on the current project with auto-fix on.