Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Python package install command from manifest #52

Merged

Conversation

sarayourfriend
Copy link
Contributor

Related to beeware/briefcase#1270

Facilitates configuration of the pip install command arguments by Briefcase or the use of a different package installer altogether without needing to re-process the template or add complex logic to the template (as would be required if the command was templated directly into the manifest).

The default contents of install_requirements.sh ensure this can be merged without waiting for Briefcase to support writing into the file (e.g., if a Briefcase version is released between this PR merging and the rest of the linked issue being implemented).

Alternatively, if the maintainers prefer, I can change the file to be blank by default, and we can wait to merge this until the Briefcase change is ready.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

re: beeware/briefcase#1270

Facilitates configuration of the pip install command arguments by Briefcase or the use of a different package installer altogether without needing to re-process the template or add complex logic to the template (as would be required if the command was templated directly into the manifest).
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@freakboy3742 freakboy3742 merged commit 89f9578 into beeware:main Nov 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants