Allow configuration of pip options #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsmith
reviewed
Nov 16, 2024
There was a problem hiding this comment.
Yes, I think this is a good approach.
We may also want to put the path of the pip-options.txt file in briefcase.toml – let's discuss at beeware/briefcase#2059 (comment).
freakboy3742
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
This looks good to me, but I'll leave it to @mhsmith to give the final signoff (since Android is more of his area of expertise, and he's already taken a look at this PR).
mhsmith
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to beeware/briefcase#1270
This PR is roughly similar to beeware/briefcase-linux-flatpak-template#52, except that while the Flatpak PR claims to "decouple" pip install from requirement installation, that isn't as easy to do for the Android template, so far as I can tell. The implementation matches @mhsmith's recommendation from the linked issue to write the options to a text file to be read in
build.gradle.I've tested this by building an app with the template without any addition pip options, as well as by using Briefcase from this PR which adds the new
requirement_installer_argsconfiguration and is now updated to support thispip-options.txtfile. You could also just checkout this branch locally and use the template that way, with manual modifications topip-options.txtto verify that it works (i.e., that the options are applied).PR Checklist: