Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested pseudo-classes and parent reference (LESS) #427

Closed
wants to merge 1 commit into from

Conversation

nponiros
Copy link

JavaScript:
css beautifier checks if the colon it encounters
is part of a property: value or part of a nested pseudo-class/
parent reference. In case of nested pseudo-class or parent reference (LESS)
it does not output a space after the colon.

Added general test for parent reference, nested pseudo-class and
SASS import statement. Added special test for issues #410 and #414.

Python:
Best effort to support parent reference and nested pseudo-class.
When it encounters a colon it checks if the colon is part
of a property: value or part of parent reference/nested pseudo-class.
In case of parent reference/nested pseudo-class it does not output
a space after the colon.

Added tests for reference/nested pseudo-class. Add tests for
issues #410, #414

Fixes issues #410 and #414
Related to issue #356

JavaScript:
css beautifier checks if the colon it encounters
is part of a property: value or part of a nested pseudo-class/
parent reference. In case of nested pseudo-class or parent reference
it does not output a space after the colon.

Added general test for parent reference, nested pseudo-class and
SASS import statement. Added special test for issues beautifier#410 and beautifier#414.

Python:
Best effort to support parent reference and nested pseudo-class.
When it encounters a colon it checks if the colon is part
of a property: value or part of parent reference/nested pseudo-class.
In case of parent reference/nested pseudo-class it does not output
a space after the colon.

Added tests for reference/nested pseudo-class. Add tests for
issues beautifier#410, beautifier#414

Fixes issues beautifier#410 and beautifier#414
Related to issue beautifier#356
@nponiros
Copy link
Author

I saw that some people already have opened similar pull requests but I needed that for my projects so I wrote it and figured opening a pull request doesn't cost :)

Unfortunatelly I am not much of a python developer so the python changes might not really be good..

Regards
Nikolas

@noducks
Copy link

noducks commented Apr 8, 2014

Awesome. Great to see a fix for this.

@nightspirit
Copy link

Try this code with brackets-beautify https://github.com/drewhjava/brackets-beautify

It's not even beautify less file at all. Have no idea what's going on.

@bitwiseman
Copy link
Member

I believe the issues addressed here are now fixed. But I have not integrated all the tests from this PR into master.

@bitwiseman bitwiseman closed this in 18e96c4 Oct 3, 2014
@bitwiseman bitwiseman added this to the v1.6.0 milestone Oct 3, 2014
@bitwiseman
Copy link
Member

Thanks for this work. I think I got the key points, so we don't kill these anymore, but I'm sure I left a few more issues that need addressing. Any additional help you want to provide would be much appreciated.

@bitwiseman bitwiseman modified the milestones: v1.6.0, v1.5.4 Oct 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants