LESS improvements #356
Closed
LESS improvements #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we're just waiting on the python version to do this. Also needs merge resolution now. |
|
Sure I just forgot this. But I'm still very interested in getting this merged. I have more less support coming, but let's keep the PR's small for easy merges. |
… general-less Conflicts: js/lib/beautify-css.js
|
Have fixed all the isses on the js side of things.. However the python implementation was not up to date with the js one, this functionality was not implemented for instance. |
|
To avoid features to be implemented only in js or python, and to ensure 100% js/python compability, it would be a idea to extract the input/expected testcases to files. And write js/python code that loads the input, processes, and compares against the expected. That way you have 100% equal test coverage. |
nponiros
added a commit
to get-the-service/js-beautify
that referenced
this pull request
Mar 18, 2014
JavaScript: css beautifier checks if the colon it encounters is part of a property: value or part of a nested pseudo-class/ parent reference. In case of nested pseudo-class or parent reference it does not output a space after the colon. Added general test for parent reference, nested pseudo-class and SASS import statement. Added special test for issues beautifier#410 and beautifier#414. Python: Best effort to support parent reference and nested pseudo-class. When it encounters a colon it checks if the colon is part of a property: value or part of parent reference/nested pseudo-class. In case of parent reference/nested pseudo-class it does not output a space after the colon. Added tests for reference/nested pseudo-class. Add tests for issues beautifier#410, beautifier#414 Fixes issues beautifier#410 and beautifier#414 Related to issue beautifier#356
nponiros
added a commit
to get-the-service/js-beautify
that referenced
this pull request
Mar 18, 2014
JavaScript: css beautifier checks if the colon it encounters is part of a property: value or part of a nested pseudo-class/ parent reference. In case of nested pseudo-class or parent reference it does not output a space after the colon. Added general test for parent reference, nested pseudo-class and SASS import statement. Added special test for issues beautifier#410 and beautifier#414. Python: Best effort to support parent reference and nested pseudo-class. When it encounters a colon it checks if the colon is part of a property: value or part of parent reference/nested pseudo-class. In case of parent reference/nested pseudo-class it does not output a space after the colon. Added tests for reference/nested pseudo-class. Add tests for issues beautifier#410, beautifier#414 Fixes issues beautifier#410 and beautifier#414 Related to issue beautifier#356
nponiros
added a commit
to get-the-service/js-beautify
that referenced
this pull request
Mar 18, 2014
JavaScript: css beautifier checks if the colon it encounters is part of a property: value or part of a nested pseudo-class/ parent reference. In case of nested pseudo-class or parent reference it does not output a space after the colon. Added general test for parent reference, nested pseudo-class and SASS import statement. Added special test for issues beautifier#410 and beautifier#414. Python: Best effort to support parent reference and nested pseudo-class. When it encounters a colon it checks if the colon is part of a property: value or part of parent reference/nested pseudo-class. In case of parent reference/nested pseudo-class it does not output a space after the colon. Added tests for reference/nested pseudo-class. Add tests for issues beautifier#410, beautifier#414 Fixes issues beautifier#410 and beautifier#414 Related to issue beautifier#356
|
Yes, the two may not be fully up to date because we weren't being as hard core about parity. Please port the missing features or at least file issues so people know what needs porting . |
|
I took your code amended it and made further changes. The fixes are now live in v1.5.3. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase for things that do work added as well (nesting).
Python to come