Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pool.getBroadcasted() error item.hash is not a function #598

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Fixes pool.getBroadcasted() error item.hash is not a function #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ class Pool extends EventEmitter {
this.logger.debug(
'Peer requested %s %h as a %s packet (%s).',
item.isTX() ? 'tx' : 'block',
item.hash(),
item.hash,
item.hasWitness() ? 'witness' : 'normal',
peer.hostname());

Expand Down
26 changes: 26 additions & 0 deletions test/node-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ const FullNode = require('../lib/node/fullnode');
const MTX = require('../lib/primitives/mtx');
const TX = require('../lib/primitives/tx');
const Address = require('../lib/primitives/address');
const Peer = require('../lib/net/peer');
const InvItem = require('../lib/primitives/invitem');
const invTypes = InvItem.types;

const node = new FullNode({
memory: true,
Expand Down Expand Up @@ -716,6 +719,29 @@ describe('Node', function() {
assert.strictEqual(result.coinbasevalue, 125e7 + fees);
});

it('should broadcast a tx from inventory', async () => {
const rawTX1 =
'01000000011d06bce42b67f1de811a3444353fab5d400d82728a5bbf9c89978be37ad' +
'3eba9000000006a47304402200de4fd4ecc365ea90f93dbc85d219d7f1bd92ec87436' +
'48acb48b6602977e0b4302203ca2eeabed8e6f457234652a92711d66dd8eda71ed90f' +
'b6c49b3c12ce809a5d401210257654e1b0de2d8b08d514e51af5d770e9ef617ca2b25' +
'4d84dd26685fbc609ec3ffffffff0280969800000000001976a914a4ecde9642f8070' +
'241451c5851431be9b658a7fe88acc4506a94000000001976a914b9825cafc838c5b5' +
'befb70ecded7871d011af89d88ac00000000';
const tx1 = TX.fromRaw(rawTX1, 'hex');
const dummyPeer = Peer.fromOptions({
network: 'regtest',
agent: 'my-subversion',
hasWitness: () => {
return false;
}
});
const txItem = new InvItem(invTypes.TX, tx1.hash());
await node.sendTX(tx1); // add TX to inventory
const tx2 = node.pool.getBroadcasted(dummyPeer, txItem);
assert.strictEqual(tx1.txid(), tx2.txid());
});

it('should cleanup', async () => {
consensus.COINBASE_MATURITY = 100;
await node.close();
Expand Down