Skip to content

Conversation

@dgboss
Copy link
Collaborator

@dgboss dgboss commented Feb 13, 2025

  • Factors out a lot of code common to our core api and jobs into a shared_wps package.
  • Renames root .env to .env.python and updates path to this file in settings.json.
  • Moves .env location to root folder so it is accessible to all packages.
  • Fixes a few code smells

I plan to address unit test all in one go once I've factored out a jobs module.

Closes #4195

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
PSU Insights

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 93.43066% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (db9b780) to head (4e35c48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/app/jobs/fuel_type_areas_per_zone.py 0.00% 8 Missing ⚠️
api/app/utils/generate_fuel_grid_pmtiles.py 0.00% 3 Missing ⚠️
api/app/weather_models/fetch/predictions.py 84.61% 2 Missing ⚠️
api/app/hourlies.py 85.71% 1 Missing ⚠️
api/app/jobs/common_model_fetchers.py 91.66% 1 Missing ⚠️
api/app/jobs/noaa.py 85.71% 1 Missing ⚠️
api/app/utils/esri.py 0.00% 1 Missing ⚠️
api/app/utils/zone_units.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4271      +/-   ##
==========================================
- Coverage   80.28%   78.82%   -1.46%     
==========================================
  Files         311      266      -45     
  Lines       12090     9724    -2366     
  Branches      533      533              
==========================================
- Hits         9706     7665    -2041     
+ Misses       2196     1871     -325     
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested review from brettedw and conbrad February 13, 2025 21:46
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@sonarqubecloud
Copy link

@dgboss dgboss temporarily deployed to production February 18, 2025 22:34 Inactive
@dgboss dgboss merged commit 15d38f2 into main Feb 18, 2025
26 checks passed
@dgboss dgboss deleted the task/wps_shared branch February 18, 2025 22:53
@sentry
Copy link

sentry bot commented Feb 21, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ FileNotFoundError: [Errno 2] No such file or directory: '/app/app/data/2014-2023/1013.json' /percentiles/ View Issue
  • ‼️ FileNotFoundError: [Errno 2] No such file or directory: '/app/app/data/2014-2023/1013.json' /percentiles/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASA: Update fuel type information in text bulletin

4 participants