Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback form loader #679

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Feedback form loader #679

wants to merge 4 commits into from
+17 −10

Conversation

kakarlavinodkumar
Copy link
Collaborator

@kakarlavinodkumar kakarlavinodkumar commented Mar 19, 2025 •
edited
Loading

  1. Loader added for the feedback form.
  2. Deprecated subscribe function removed.
  3. Feature flag kept as it is for feedback. We will test in dev and test. Then will remove feature flag and push to prod.

@kakarlavinodkumar kakarlavinodkumar added the Ready For Review PR is code-complete (or very close) and only needs some review and/or manual testing label Mar 20, 2025
AdityaMantripragada
AdityaMantripragada reviewed Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@AdityaMantripragada AdityaMantripragada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to keep the feature flag in place for now, push all feedback related changes to the dev env, and test them. Once everything is stable, we can handle the removal of the feature flag in a separate PR. What are your thoughts on this approach?

@kakarlavinodkumar
Copy link
Collaborator Author

It might be helpful to keep the feature flag in place for now, push all feedback related changes to the dev env, and test them. Once everything is stable, we can handle the removal of the feature flag in a separate PR. What are your thoughts on this approach?

Yes. We can do in that way.

@kakarlavinodkumar
Copy link
Collaborator Author

kakarlavinodkumar commented Mar 24, 2025 •
edited
Loading

It might be helpful to keep the feature flag in place for now, push all feedback related changes to the dev env, and test them. Once everything is stable, we can handle the removal of the feature flag in a separate PR. What are your thoughts on this approach?

@AdityaMantripragada I have removed the feature flag.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

AdityaMantripragada
AdityaMantripragada approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@AdityaMantripragada AdityaMantripragada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaMantripragada AdityaMantripragada AdityaMantripragada approved these changes

@Paahn Paahn Awaiting requested review from Paahn

@james-hollinger james-hollinger Awaiting requested review from james-hollinger

Assignees
No one assigned
Labels
Ready For Review PR is code-complete (or very close) and only needs some review and/or manual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakarlavinodkumar @AdityaMantripragada