Skip to content

Commit 66f60cc

Browse files
feature flag removed.
1 parent eb0d4f9 commit 66f60cc

File tree

4 files changed

+4
-18
lines changed

4 files changed

+4
-18
lines changed

workspace/apps/pidp/src/app/features/shell/components/navbar-menu/nav-menu.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<span
1111
[ngClass]="{'menu-notification-dot': alerts?.includes(AlertCode.TRANSIENT_ERROR) || alerts?.includes(AlertCode.PLR_BAD_STANDING)}"></span>
1212
</button>
13-
<app-feedback-button *ngIf="featureFlag()"></app-feedback-button>
13+
<app-feedback-button></app-feedback-button>
1414
</div>
1515
<div *ngIf="isTopMenuVisible" uiPidpInjectViewportCss>
1616
<div class="content-menu">

workspace/apps/pidp/src/app/features/shell/components/navbar-menu/nav-menu.ts

-7
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ import { AccessRoutes } from '@app/features/access/access.routes';
4646
import { IdentityProvider } from '@app/features/auth/enums/identity-provider.enum';
4747
import { AlertCode } from '@app/features/portal/enums/alert-code.enum';
4848
import { ProfileRoutes } from '@app/features/profile/profile.routes';
49-
import { PermissionsService } from '@app/modules/permissions/permissions.service';
50-
import { Role } from '@app/shared/enums/roles.enum';
5149

5250
import { FeedbackButtonComponent } from '../../../../shared/components/feedback-button/feedback-button.component';
5351
import { Credential } from './nav-menu.model';
@@ -107,7 +105,6 @@ export class NavMenuComponent implements OnChanges, OnInit, OnDestroy {
107105
private router: Router,
108106
private resource: NavMenuResource,
109107
private partyService: PartyService,
110-
private readonly permissionsService: PermissionsService,
111108
) {
112109
this.viewportService.viewportBroadcast$.subscribe((viewport) =>
113110
this.onViewportChange(viewport),
@@ -116,10 +113,6 @@ export class NavMenuComponent implements OnChanges, OnInit, OnDestroy {
116113
this.credentials$ = this.resource.getCredentials(partyId);
117114
}
118115

119-
public featureFlag(): boolean {
120-
return this.permissionsService.hasRole([Role.FEATURE_PIDP_DEMO]);
121-
}
122-
123116
public ngOnInit(): void {
124117
this.handleLinkedAccounts();
125118
}

workspace/apps/pidp/src/app/features/shell/components/portal-dashboard/portal-dashboard.component.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
(logout)="onLogout()">
77
</app-nav-menu>
88

9-
<app-feedback-button *ngIf="featureFlag()"></app-feedback-button>
9+
<app-feedback-button></app-feedback-button>

workspace/apps/pidp/src/app/features/shell/components/portal-dashboard/portal-dashboard.component.ts

+2-9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { AsyncPipe, NgIf } from '@angular/common';
1+
import { AsyncPipe } from '@angular/common';
22
import { Component, Inject, OnInit } from '@angular/core';
33
import { IsActiveMatchOptions } from '@angular/router';
44

@@ -19,8 +19,6 @@ import { AuthService } from '@app/features/auth/services/auth.service';
1919
import { AlertCode } from '@app/features/portal/enums/alert-code.enum';
2020
import { PortalResource } from '@app/features/portal/portal-resource.service';
2121
import { ProfileRoutes } from '@app/features/profile/profile.routes';
22-
import { PermissionsService } from '@app/modules/permissions/permissions.service';
23-
import { Role } from '@app/shared/enums/roles.enum';
2422

2523
import { FeedbackButtonComponent } from '../../../../shared/components/feedback-button/feedback-button.component';
2624
import { NavMenuComponent } from '../navbar-menu/nav-menu';
@@ -30,7 +28,7 @@ import { NavMenuComponent } from '../navbar-menu/nav-menu';
3028
templateUrl: './portal-dashboard.component.html',
3129
styleUrls: ['./portal-dashboard.component.scss'],
3230
standalone: true,
33-
imports: [AsyncPipe, NavMenuComponent, FeedbackButtonComponent, NgIf],
31+
imports: [AsyncPipe, NavMenuComponent, FeedbackButtonComponent],
3432
})
3533
export class PortalDashboardComponent implements IDashboard, OnInit {
3634
public logoutRedirectUrl: string;
@@ -50,7 +48,6 @@ export class PortalDashboardComponent implements IDashboard, OnInit {
5048
private partyService: PartyService,
5149
private resource: PortalResource,
5250
private dataService: CommonDataService,
53-
private readonly permissionsService: PermissionsService,
5451
) {
5552
this.logoutRedirectUrl = `${this.config.applicationUrl}/${this.config.routes.auth}`;
5653
this.headerConfig = { theme: 'light', allowMobileToggle: true };
@@ -68,10 +65,6 @@ export class PortalDashboardComponent implements IDashboard, OnInit {
6865
this.authService.logout(this.logoutRedirectUrl);
6966
}
7067

71-
public featureFlag(): boolean {
72-
return this.permissionsService.hasRole([Role.FEATURE_PIDP_DEMO]);
73-
}
74-
7568
public ngOnInit(): void {
7669
this.alertStatusCheck();
7770
this.dataService.pushEvent.subscribe(() => this.alertStatusCheck());

0 commit comments

Comments
 (0)