#4390 - CAS Manual Intervention: Add CASInvoiceStatusUpdatedBy Column
#4467
Conversation
- Added the CASInvoiceStatusUpdatedBy column
- Added system user as the "invoiceStatusUpdatedBy" for the createInvoices method.
sh16011993
changed the title
CASInvoiceStatusUpdatedBy Column
| UPDATE | ||
| sims.cas_invoices | ||
| SET | ||
| invoice_status_updated_by = ( |
There was a problem hiding this comment.
Can we not use the creator value from same column? - Even though creator is nullable current code ensures that creator is saved during invoice creation process.
There was a problem hiding this comment.
@dheepak-aot I had checked with @andrewsignori-aot on this during the implementation. He mentioned that for the existing records I should assign this column value to be the system-user.
There was a problem hiding this comment.
Which is the same effect from assigning the creator. Advantage is it will simplify the SQL. Let me know if there is a reason to not go this way. Not a blocker.
There was a problem hiding this comment.
To me, it is just that the new column should have a meaningful value. I am okay with either of them.
There was a problem hiding this comment.
Also, if we go with the system-user there will be a distinction between the pre-existing records vs the ones that will come into the database after this code push since afterwards it will be the ministry user doing the update.
...ges/backend/apps/queue-consumers/src/services/cas-invoice-batch/cas-invoice-batch.service.ts
Outdated
Show resolved
Hide resolved
- SQL Update - constant creation
| WHERE | ||
| last_name = 'system-user' | ||
| ); | ||
| invoice_status_updated_by = creator; |
There was a problem hiding this comment.
Please update the comment -- Update the existing records with the system user.
- Updated the comment
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
E2E Workflow Workers Coverage Report
|
sh16011993
deleted the
4390_cas_manual_intervention_migration_add_column
branch
As a part of this PR, the following have been completed:
CASInvoiceStatusUpdatedBycolumn.Rollback Screenshot: