Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAS Manual Intervention Table #4390

Closed
23 tasks
ninosamson opened this issue Feb 25, 2025 · 2 comments
Closed
23 tasks

CAS Manual Intervention Table #4390

ninosamson opened this issue Feb 25, 2025 · 2 comments
Assignees
@sh16011993
Milestone
Full-Time "Asset"

Comments

@ninosamson
Copy link
Collaborator

ninosamson commented Feb 25, 2025 •
edited by sh16011993
Loading

  • Create new UI table to include individual invoice error records (Manual Intervention).
  • Each record should include the response (CAS request?) date, batch name, invoice number, supplier number, error information.
  • Each record can be actioned:
    • 'Resolved' to indicate user has dealt with it directly within CAS.
    • When resolved, track which user resolved it and when it was resolved.

Technical AC

  • Decision to reuse the same Ministry role aest-cas-invoicing as business did not provide one and it was ok with it.

DB

  • Create a migration status Resolved in invoice_status in cas_invoices table.
  • Create a migration to capture the user changing the status using the same naming conventions from other tables doing the same.

API

  • Create a new controller named cas-invoice
    • New endpoint to get list of manual intervention invoices from cas-invoices table, with lazy pagination enabled.
    • New endpoint to update the status.
  • The response date shall be invoice_status_updated_on from the table.
  • Sort on last invoice update date ASC first.
  • Create an api patch request to update status to Resolve, which validates the Ministry role to make the update and persist the user executing the update.
  • Update Audit DB Column on update about user action.

UI

  • Create a V-Datable-Server Datatable to view Manual Intervention below invoice batch in Ministry portal.
  • Show error in expander in UI (similar to CAS supplier).
  • Use the action button to resolve the status from Manual Intervention to Resolved.
  • Show a Modal to confirm the action to change status, using the component confirm-modal.
  • Action should be enabled only for a user with a valid role.
  • Enable the sort on first database column Response date.
  • Once some record is actioned, refresh the result table.

E2E

  • E2E test for new API endpoints.
@ninosamson ninosamson added the Dev & Architecture Development and Architecture label Feb 25, 2025
@bidyashish
Copy link
Collaborator

Question for @CarlyCotton

  • which ministry role to make the update?
  • Should Ddatable show resolved status based on filter or will it be seperate task?

@CarlyCotton
Copy link
Collaborator

@bidyashish

  • Could have it's own or be attached to the role needed to view the page: aest-cas-invoicing
  • Datatable: Can just be invoices that are manual intervention. Do not need to include a filter and resolved invoices at this time.

@ninosamson ninosamson added this to the Full-Time "Asset" milestone Mar 3, 2025
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Mar 4, 2025
sh16011993 added a commit that referenced this issue Mar 7, 2025
@sh16011993
#4390 - CAS Manual Intervention (DB Migration)
57a1d2f 
- Created a migration status `Resolved` in `invoice_status` column in `cas_invoices` table.
github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2025
@sh16011993
#4390 - CAS Manual Intervention (DB Migration) (#4446)
9a8c8f4 
### As a part of this PR, the following have been completed:

- Created a migration status `Resolved` in `invoice_status` column in
`cas_invoices` table.
- `CASInvoiceStatus` enum updated in the backend with the newly added
`Resolved` status.

**Rollback Screenshot**

<img width="872" alt="image"
src="https://github.com/user-attachments/assets/81eb9fb6-4fe0-4686-8814-0785d25c3b35"
/>
sh16011993 added a commit that referenced this issue Mar 12, 2025
@sh16011993
#4390 - CAS Manual Intervention: Add Column
b373908 
- Added the CASInvoiceStatusUpdatedBy column
github-merge-queue bot pushed a commit that referenced this issue Mar 12, 2025
@sh16011993
#4390 - CAS Manual Intervention: Add CASInvoiceStatusUpdatedBy Colu…
50d34ef 
…mn (#4467)

### As a part of this PR, the following have been completed:

- Added the migration for the `CASInvoiceStatusUpdatedBy` column.

**Rollback Screenshot:**

<img width="815" alt="image"
src="https://github.com/user-attachments/assets/43a2d311-ab3e-43b1-9c65-0124a6e0dff7"
/>
sh16011993 added a commit that referenced this issue Mar 12, 2025
@sh16011993
#4390 - CAS Manual Intervention (API)
594ed37
sh16011993 added a commit that referenced this issue Mar 12, 2025
@sh16011993
#4390 - CAS Manual Intervention (UI)
ba4516e
github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2025
@sh16011993
#4390 - CAS Manual Intervention (API) (#4469)
8dffac0 
### As a part of this PR, the following were completed:

- Created a new controller named `cas-invoice` with the two below
endpoints:
1) Create new endpoint to get list of manual intervention invoices from
`cas-invoices` table, with lazy pagination enabled.
   2) Created new endpoint to update the status of the `cas-invoices`.
github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2025
@sh16011993
#4390 - CAS Manual Intervention (UI) (#4470)
8e7152e 
### As a part of this PR, the following were completed:

- Created a V-Datable-Server type datatable to view Manual Intervention
below invoice batch in Ministry portal.
- Added the expander to show the errors in UI.
- Added the action button to resolve the status from Manual Intervention
to Resolved.
- Created the modal to confirm the action to change status using the
component `confirm-modal`.
- Added the role to ensure that the action is enabled only for a user
with a valid role.
- Enabled the sort on first database column `Response date`.

**Video representing the demo:**


https://github.com/user-attachments/assets/140dd45d-c881-45ae-9a84-18730db9bef9

### **Screenshots:**

**Manual Intervention Table**

<img width="1923" alt="image"
src="https://github.com/user-attachments/assets/98e2fc77-af72-484c-a03f-51fd3e6d9f78"
/>


-----------------------------------------------------------------------------------------------------------

**Modal Confirmation Dialog**

<img width="1917" alt="image"
src="https://github.com/user-attachments/assets/0b238da1-3be6-4279-a526-e26d5fd21e5d"
/>
sh16011993 added a commit that referenced this issue Mar 14, 2025
@sh16011993
#4390 - CAS Manual Intervention: e2e tests
f0fbad4
github-merge-queue bot pushed a commit that referenced this issue Mar 18, 2025
@sh16011993
#4390 - CAS Manual Intervention (e2e tests) (#4478)
d766304 
### As a part of this PR, the following e2e tests have been written:

- **CASInvoiceAESTController(e2e)-updateInvoiceToResolved**
√ Should resolve an invoice in Manual intervention status for the
provided invoice identifier.
√ Should throw a HttpStatus Not Found (404) error when the CAS invoice
to resolve doesn't exist.
√ Should throw a HttpStatus Not Found (404) error when the CAS invoice
to resolve does not have the expected Manual intervention status.
√ Should throw a HttpStatus Forbidden (403) error when an unauthorized
Ministry user tries to update the invoice.

- **CASInvoiceAESTController(e2e)-getInvoices**
√ Should be able to get invoices for the first page in a paginated
result with a limit of two per page with Manual intervention status in
the descending order.
√ Should throw a HttpStatus Bad Request (400) error when the invoice
status is invalid.
√ Should throw a HttpStatus Bad Request (400) error when the sortField
is invalid.
√ Should throw a HttpStatus Forbidden (403) error when an unauthorized
Ministry user tries to get the invoices.

**Screenshots for the above e2e test execution:**

<img width="1059" alt="image"
src="https://github.com/user-attachments/assets/fb5ed187-aa04-46a3-87b7-63c4fd5d90d6"
/>


---------------------------------------------------------------------------------------------------------------------

<img width="1145" alt="image"
src="https://github.com/user-attachments/assets/968e1bc4-8818-46fc-93c4-d59d682e1b02"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh16011993 sh16011993

Labels
None yet
Projects
None yet
Milestone
Full-Time "Asset"
Development

No branches or pull requests
6 participants
@sh16011993 @bidyashish @ninosamson @andrewsignori-aot @andrepestana-aot @CarlyCotton