#4136 - Ecert File Creation - Need to generate 0 record files #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
reviewed
Dec 30, 2024
...egration/ecert-integration/_tests_/ecert-full-time-process-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2024
...egration/ecert-integration/_tests_/ecert-full-time-process-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2024
...egration/ecert-integration/_tests_/ecert-part-time-process-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2024
...egration/ecert-integration/_tests_/ecert-part-time-process-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2024
...egration/ecert-integration/_tests_/ecert-part-time-process-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2024
...ges/backend/libs/integrations/src/esdc-integration/e-cert-integration/e-cert-file-handler.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 30, 2024
...ges/backend/libs/integrations/src/esdc-integration/e-cert-integration/e-cert-file-handler.ts
Outdated
Show resolved
Hide resolved
|
Good Job @bidyashish please take a look at the comments. |
dheepak-aot
reviewed
Dec 31, 2024
| @@ -1381,5 +1398,12 @@ describe( | |||
| ]); | |||
| }, | |||
| ); | |||
|
|
|||
| // Helper function to get the uploaded file name. | |||
There was a problem hiding this comment.
Please use the method comments in this way.
/**
* Helper function to get the uploaded file name.
* @returns The uploaded file name
*/
dheepak-aot
approved these changes
Dec 31, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Technical
Demo
1st E-cert File:
2nd E-cert File with 0 records:
