Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4130 - Update Openshift Github Actions (#4131) #4161

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

bidyashish
Copy link
Collaborator

  • Added the openshift-tools-installer to all action steps that require some OC iteration.
  • Using the default options.
  • Using the fixed version "4". The current version printed is OC CLI Version: Client Version: 4.17.9.

Please note, for steps printing the OC version, the new action was added before the print step. For steps not printing the OC version, the new step was added right before the "Log in to OpenShift".

Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119

- Added the
[openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer)
to all action steps that require some OC iteration.
- Using the [default
options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs).
- Using the fixed version "4". The current version printed is `OC CLI
Version: Client Version: 4.17.9`.

Please note, for steps printing the `OC version`, the new action was
added before the print step. For steps not printing the `OC version`,
the new step was added right before the "Log in to OpenShift".

Sample workflow execution with the new step working:
https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.94% ( 3786 / 17255 )
Methods: 9.99% ( 219 / 2192 )
Lines: 25.29% ( 3281 / 12971 )
Branches: 13.67% ( 286 / 2092 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 80% ( 1336 / 1670 )
Methods: 63.55% ( 136 / 214 )
Lines: 83.49% ( 1123 / 1345 )
Branches: 69.37% ( 77 / 111 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@andrewsignori-aot andrewsignori-aot added the Branch Sync-up Branch features move between main/release/hotfix branches. label Dec 20, 2024
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bidyashish bidyashish merged commit e1ba70a into release/v2.2.0 Dec 20, 2024
21 checks passed
@bidyashish bidyashish deleted the cherry-pick/#github-action branch December 20, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch Sync-up Branch features move between main/release/hotfix branches.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants