-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4130 - Update Openshift Github Actions #4131
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for adding Openshift CLI to Github actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 👍Thanks for taking care of the issue.
- Added the [openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer) to all action steps that require some OC iteration. - Using the [default options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs). - Using the fixed version "4". The current version printed is `OC CLI Version: Client Version: 4.17.9`. Please note, for steps printing the `OC version`, the new action was added before the print step. For steps not printing the `OC version`, the new step was added right before the "Log in to OpenShift". Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
- Added the [openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer) to all action steps that require some OC iteration. - Using the [default options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs). - Using the fixed version "4". The current version printed is `OC CLI Version: Client Version: 4.17.9`. Please note, for steps printing the `OC version`, the new action was added before the print step. For steps not printing the `OC version`, the new step was added right before the "Log in to OpenShift". Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
- Added the [openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer) to all action steps that require some OC iteration. - Using the [default options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs). - Using the fixed version "4". The current version printed is `OC CLI Version: Client Version: 4.17.9`. Please note, for steps printing the `OC version`, the new action was added before the print step. For steps not printing the `OC version`, the new step was added right before the "Log in to OpenShift". Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
OC CLI Version: Client Version: 4.17.9
.Please note, for steps printing the
OC version
, the new action was added before the print step. For steps not printing theOC version
, the new step was added right before the "Log in to OpenShift".Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119