Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4130 - Update Openshift Github Actions #4131

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Dec 17, 2024

  • Added the openshift-tools-installer to all action steps that require some OC iteration.
  • Using the default options.
  • Using the fixed version "4". The current version printed is OC CLI Version: Client Version: 4.17.9.

Please note, for steps printing the OC version, the new action was added before the print step. For steps not printing the OC version, the new step was added right before the "Log in to OpenShift".

Sample workflow execution with the new step working: https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119

@andrewsignori-aot andrewsignori-aot added the Devops Devops label Dec 17, 2024
@andrewsignori-aot andrewsignori-aot self-assigned this Dec 17, 2024
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22% ( 3786 / 17207 )
Methods: 10.01% ( 219 / 2187 )
Lines: 25.38% ( 3281 / 12930 )
Branches: 13.68% ( 286 / 2090 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 80.48% ( 1328 / 1650 )
Methods: 64.59% ( 135 / 209 )
Lines: 83.83% ( 1115 / 1330 )
Branches: 70.27% ( 78 / 111 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review December 17, 2024 18:17
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for adding Openshift CLI to Github actions.

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍Thanks for taking care of the issue.

@andrewsignori-aot andrewsignori-aot added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 64a1504 Dec 17, 2024
29 checks passed
@andrewsignori-aot andrewsignori-aot deleted the install-oc-github-actions branch December 19, 2024 21:18
bidyashish pushed a commit that referenced this pull request Dec 20, 2024
- Added the
[openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer)
to all action steps that require some OC iteration.
- Using the [default
options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs).
- Using the fixed version "4". The current version printed is `OC CLI
Version: Client Version: 4.17.9`.

Please note, for steps printing the `OC version`, the new action was
added before the print step. For steps not printing the `OC version`,
the new step was added right before the "Log in to OpenShift".

Sample workflow execution with the new step working:
https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
bidyashish pushed a commit that referenced this pull request Dec 20, 2024
- Added the
[openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer)
to all action steps that require some OC iteration.
- Using the [default
options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs).
- Using the fixed version "4". The current version printed is `OC CLI
Version: Client Version: 4.17.9`.

Please note, for steps printing the `OC version`, the new action was
added before the print step. For steps not printing the `OC version`,
the new step was added right before the "Log in to OpenShift".

Sample workflow execution with the new step working:
https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
bidyashish added a commit that referenced this pull request Dec 20, 2024
- Added the
[openshift-tools-installer](https://github.com/redhat-actions/openshift-tools-installer)
to all action steps that require some OC iteration.
- Using the [default
options](https://github.com/redhat-actions/openshift-tools-installer?tab=readme-ov-file#inputs).
- Using the fixed version "4". The current version printed is `OC CLI
Version: Client Version: 4.17.9`.

Please note, for steps printing the `OC version`, the new action was
added before the print step. For steps not printing the `OC version`,
the new step was added right before the "Log in to OpenShift".

Sample workflow execution with the new step working:
https://github.com/bcgov/SIMS/actions/runs/12378896945/job/34551860119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devops Devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants