Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3768 - CAS Supplier Updates Report - Saving Snapshot #4011

Merged
merged 3 commits into from
Nov 28, 2024
Merged

#3768 - CAS Supplier Updates Report - Saving Snapshot #4011

merged 3 commits into from
Nov 28, 2024

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Nov 28, 2024 •
edited
Loading

Added Saving the Snapshot

image

@dheepak-aot dheepak-aot self-assigned this Nov 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.07% ( 3742 / 16953 )
Methods: 10.15% ( 214 / 2108 )
Lines: 25.41% ( 3250 / 12789 )
Branches: 13.52% ( 278 / 2056 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.45% ( 1244 / 1473 )
Methods: 84.51% ( 120 / 142 )
Lines: 85.68% ( 1059 / 1236 )
Branches: 68.42% ( 65 / 95 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.09% ( 5837 / 8700 )
Methods: 64.86% ( 720 / 1110 )
Lines: 71.08% ( 4588 / 6455 )
Branches: 46.61% ( 529 / 1135 )

@dheepak-aot dheepak-aot marked this pull request as ready for review November 28, 2024 18:08
@lewischen-aot lewischen-aot self-requested a review November 28, 2024 18:49
andrewsignori-aot
andrewsignori-aot reviewed Nov 28, 2024
View reviewed changes
sources/packages/backend/apps/api/src/constants/error-code.constants.ts
@@ -239,3 +239,7 @@ export const APPLICATION_RESTRICTION_BYPASS_NOT_FOUND =
*/
export const APPLICATION_RESTRICTION_BYPASS_IS_NOT_ACTIVE =
"APPLICATION_RESTRICTION_BYPASS_IS_NOT_ACTIVE";
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a blank line to follow the file's existing pattern.

andrewsignori-aot
andrewsignori-aot approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, looks good 👍

lewischen-aot
lewischen-aot approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great job 👍

@dheepak-aot dheepak-aot added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 07ef0ea Nov 28, 2024
20 checks passed
@dheepak-aot dheepak-aot deleted the feature/#3768-cas-supplier-maintenance-updates-2 branch December 4, 2024 16:29
@dheepak-aot dheepak-aot mentioned this pull request Dec 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@lewischen-aot lewischen-aot lewischen-aot approved these changes

Assignees

@dheepak-aot dheepak-aot

Labels
Queue Consumers SIMS-Api SIMS-Api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dheepak-aot @andrewsignori-aot @lewischen-aot