-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3768 - Report Creation and E2E tests #4039
#3768 - Report Creation and E2E tests #4039
Conversation
sources/packages/backend/apps/api/src/route-controllers/report/report.controller.service.ts
Show resolved
Hide resolved
...api/src/route-controllers/report/_tests_/e2e/report.aest.controller.exportReport.e2e-spec.ts
Show resolved
Hide resolved
...api/src/route-controllers/report/_tests_/e2e/report.aest.controller.exportReport.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...ackend/apps/db-migrations/src/sql/Reports/Create-cas-supplier-maintenance-updates-report.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, please take a look at the comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @dheepak-aot
Report Creation
CAS Supplier Maintenance Updates
which captures the updates from student since their CAS Supplier is set to be valid.To identify the students who had one or more updates to their profile from CAS perspective, student profile data is compared with the
student_profile_snapshot
column of CAS supplier.Note: All the data comparisons are string comparison ignoring the case.
Data is sorted by
sims.students.updated_at
Byte Order Mark Update: Update the code to NOT add the BYTE ORDER MARK character when report is empty as it is not required.
Rollback Evidence
E2E Tests