Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3768 - Report Creation and E2E tests #4039

Merged
merged 15 commits into from
Dec 11, 2024

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Dec 6, 2024

Report Creation

  • Created a new dynamic report CAS Supplier Maintenance Updates which captures the updates from student since their CAS Supplier is set to be valid.
    image

image

  • To identify the students who had one or more updates to their profile from CAS perspective, student profile data is compared with the student_profile_snapshot column of CAS supplier.
    Note: All the data comparisons are string comparison ignoring the case.

  • Data is sorted by sims.students.updated_at

  • Byte Order Mark Update: Update the code to NOT add the BYTE ORDER MARK character when report is empty as it is not required.

Rollback Evidence

image

E2E Tests

  • Added E2E tests to validate the report data when student updates their
    • Last name
    • SIN
    • Address line 1
    • Postal code
  • Added E2E test to ensure the comparison of data is not case sensitive. (Used last name as scenario).

image

@dheepak-aot dheepak-aot self-assigned this Dec 6, 2024
@dheepak-aot dheepak-aot marked this pull request as ready for review December 11, 2024 05:54
@guru-aot guru-aot self-requested a review December 11, 2024 16:35
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, please take a look at the comments.

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.95% ( 3755 / 17109 )
Methods: 10.08% ( 215 / 2132 )
Lines: 25.3% ( 3260 / 12886 )
Branches: 13.39% ( 280 / 2091 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.94% ( 1342 / 1580 )
Methods: 83.33% ( 135 / 162 )
Lines: 86.45% ( 1129 / 1306 )
Branches: 69.64% ( 78 / 112 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, look good 👍

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.27% ( 5902 / 8773 )
Methods: 64.85% ( 725 / 1118 )
Lines: 71.23% ( 4633 / 6504 )
Branches: 47.26% ( 544 / 1151 )

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @dheepak-aot

@dheepak-aot dheepak-aot added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 9547f75 Dec 11, 2024
21 checks passed
@dheepak-aot dheepak-aot deleted the feature/#3768-cas-supplier-maintenance-updates-3 branch December 13, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants