-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3877 - Setup Program Year 2025 - 2026 #3997
Conversation
'2025-2026', | ||
'Study starting between August 01, 2025 and July 31, 2026', | ||
'SFAA2025-26', | ||
TRUE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be false
:
"Please set active to false for this program year in production until advised otherwise"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we change it just for prod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the release instruction to be set to is_active = false
just for PROD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just leave a comment for the instructions for prod. If the migration is true, it's important to include the release instructions to change it for prod.
VALUES | ||
( | ||
'2025-2026', | ||
'Study starting between August 01, 2025 and July 31, 2026', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the description (similar to the pre-existing ones as shown in your comment) for the newly added program year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dheepak-aot . I had made the change you are referring to but just realized that I forgot to push the file to remote.
Quality Gate passedIssues Measures |
@@ -142,6 +142,47 @@ | |||
<text>25</text> | |||
</outputEntry> | |||
</rule> | |||
<rule id="DecisionRule_15szag4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not be part of the PR.
In the FT DMNs some of them start with 2021-2022
, 2022-2023
, 2023-2024
. Is there a particular reason for that? or it is just pending a cleanup.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, they do not need to be removed.
If the point is that they will never going to be real production ones we can clean up (with biz approval).
For real production ones, we should keep them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Looks good. 👍
As a part of this PR, the following are completed:
fulltime-assessment-2024-2025.bpmn
andparttime-assessment-2024-2025.bpmn
) from the previous year and adjusted them as per the wiki.fulltime-assessment-decisions.dmn
andparttime-assessment-decisions.dmn
) copying the existing 2024-2025 values.sfaa2025-26.json
,supportingusersparent2025-2026.json
,supportinguserspartner2025-2026.json
is_active
to false for this program year in production has been added to the release instructions.Migration Revert Screenshot:
The following tests were performed after the above mentioned updates: