Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3877 - Setup Program Year 2025 - 2026 #3997

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Nov 26, 2024

As a part of this PR, the following are completed:

  • Duplicated the BPMN files (fulltime-assessment-2024-2025.bpmn and parttime-assessment-2024-2025.bpmn) from the previous year and adjusted them as per the wiki.
  • Added new 2025-2026 values in the DMN tables (for both fulltime-assessment-decisions.dmn and parttime-assessment-decisions.dmn) copying the existing 2024-2025 values.
  • Copied, renamed and adjusted the following form.io definitions: sfaa2025-26.json, supportingusersparent2025-2026.json, supportinguserspartner2025-2026.json
  • Created the new program year entry in DB
  • Created a new suite of E2E tests for the new program year
  • Set is_active to false for this program year in production has been added to the release instructions.

Migration Revert Screenshot:

image

The following tests were performed after the above mentioned updates:

  • Tested application submission and generation of NOA for the newly added program year
image
image

@sh16011993 sh16011993 self-assigned this Nov 26, 2024
@sh16011993 sh16011993 added Form.io Form IO definitions changed. E2E/Unit tests DB DB migration involved Camunda Worflow Involves camunda workflow changes labels Nov 26, 2024
@andrepestana-aot andrepestana-aot self-requested a review November 26, 2024 17:07
'2025-2026',
'Study starting between August 01, 2025 and July 31, 2026',
'SFAA2025-26',
TRUE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be false:

"Please set active to false for this program year in production until advised otherwise"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we change it just for prod?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the release instruction to be set to is_active = false just for PROD.

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just leave a comment for the instructions for prod. If the migration is true, it's important to include the release instructions to change it for prod.

@dheepak-aot dheepak-aot self-requested a review November 26, 2024 18:01
VALUES
(
'2025-2026',
'Study starting between August 01, 2025 and July 31, 2026',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the program year descriptions are like this.
image

Is there a requirement to change the description into new format? let me know if I am missing something here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added the description (similar to the pre-existing ones as shown in your comment) for the newly added program year.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dheepak-aot . I had made the change you are referring to but just realized that I forgot to push the file to remote.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.07% ( 3733 / 16912 )
Methods: 10.16% ( 214 / 2107 )
Lines: 25.42% ( 3241 / 12750 )
Branches: 13.53% ( 278 / 2055 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@@ -142,6 +142,47 @@
<text>25</text>
</outputEntry>
</rule>
<rule id="DecisionRule_15szag4">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not be part of the PR.
In the FT DMNs some of them start with 2021-2022, 2022-2023, 2023-2024. Is there a particular reason for that? or it is just pending a cleanup.?

image

image

image

@andrewsignori-aot @guru-aot @andrepestana-aot ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, they do not need to be removed.
If the point is that they will never going to be real production ones we can clean up (with biz approval).
For real production ones, we should keep them.

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.39% ( 1238 / 1467 )
Methods: 84.51% ( 120 / 142 )
Lines: 85.61% ( 1053 / 1230 )
Branches: 68.42% ( 65 / 95 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Looks good. 👍

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.04% ( 5810 / 8667 )
Methods: 64.86% ( 720 / 1110 )
Lines: 70.99% ( 4561 / 6425 )
Branches: 46.73% ( 529 / 1132 )

@sh16011993 sh16011993 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 3b1a780 Nov 27, 2024
20 checks passed
@sh16011993 sh16011993 deleted the 3877_setup_program_year_25_26 branch November 27, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda Worflow Involves camunda workflow changes DB DB migration involved E2E/Unit tests Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants