Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3878 - Update PTMSFAA File Name #3880

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Nov 1, 2024

Added a gap to skip some sequence numbers while generating the MSFAA sequence to avoid conflicts with legacy MSFAA.

Copy link

sonarqubecloud bot commented Nov 1, 2024

Copy link

github-actions bot commented Nov 1, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.91% ( 3497 / 15964 )
Methods: 9.89% ( 197 / 1991 )
Lines: 25.6% ( 3083 / 12043 )
Branches: 11.24% ( 217 / 1930 )

Copy link

github-actions bot commented Nov 1, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

Copy link

github-actions bot commented Nov 1, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.09% ( 1058 / 1229 )
Methods: 87.3% ( 110 / 126 )
Lines: 87.08% ( 903 / 1037 )
Branches: 68.18% ( 45 / 66 )

Copy link

github-actions bot commented Nov 1, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 65.62% ( 5524 / 8418 )
Methods: 63.14% ( 680 / 1077 )
Lines: 69.75% ( 4367 / 6261 )
Branches: 44.17% ( 477 / 1080 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review November 1, 2024 22:08
@andrewsignori-aot andrewsignori-aot added the Hotfix PR created for hotfix label Nov 1, 2024
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @andrewsignori-aot 👍

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍Thanks for the quick PR.

@andrewsignori-aot andrewsignori-aot merged commit db39bab into hotfix/v1.14.1 Nov 1, 2024
20 checks passed
@andrewsignori-aot andrewsignori-aot deleted the feature/#3878-ptmsfaa-file-name branch November 1, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotfix PR created for hotfix Queue Consumers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants