Skip to content

Commit db39bab

Browse files
#3878 - Update PTMSFAA File Name (#3880)
Added a gap to skip some sequence numbers while generating the MSFAA sequence to avoid conflicts with legacy MSFAA.
1 parent 20389ad commit db39bab

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

sources/packages/backend/apps/queue-consumers/src/processors/schedulers/esdc-integration/msfaa-integration/_tests_/msfaa-part-time-process-integration.scheduler.e2e-spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ describe(
8484
getProcessDateFromMSFAARequestContent(createMSFAARequestContentMock);
8585
const uploadedFile = getUploadedFile(sftpClientMock);
8686
expect(uploadedFile.remoteFilePath).toBe(
87-
`MSFT-Request\\DPBC.EDU.MSFA.SENT.PT.${processDateFormatted}.001`,
87+
`MSFT-Request\\DPBC.EDU.MSFA.SENT.PT.${processDateFormatted}.010`,
8888
);
8989
// Assert process result.
9090
expect(msfaaRequestResults).toStrictEqual([
@@ -106,7 +106,7 @@ describe(
106106
] = uploadedFile.fileLines;
107107
// Validate header.
108108
expect(header).toBe(
109-
`100BC MSFAA SENT ${processDateFormatted}${processTimeFormatted}000001 `,
109+
`100BC MSFAA SENT ${processDateFormatted}${processTimeFormatted}000010 `,
110110
);
111111
// Validate records.
112112
expect(msfaaPartTimeMarried).toBe(

sources/packages/backend/libs/integrations/src/esdc-integration/msfaa-integration/msfaa-request.processing.service.ts

+5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import { MSFAAIntegrationService } from "./msfaa.integration.service";
1212
import { ESDCFileHandler } from "../esdc-file-handler";
1313
import { ConfigService } from "@sims/utilities/config";
1414
import { MSFAANumberService } from "@sims/integrations/services";
15+
import { MSFAA_SEQUENCE_GAP } from "@sims/services/constants";
1516

1617
@Injectable()
1718
export class MSFAARequestProcessingService extends ESDCFileHandler {
@@ -76,6 +77,10 @@ export class MSFAARequestProcessingService extends ESDCFileHandler {
7677
)}`,
7778
async (nextSequenceNumber: number, entityManager: EntityManager) => {
7879
try {
80+
this.logger.log(
81+
`Applying MSFAA sequence gap to the sequence number. Current sequence gap ${MSFAA_SEQUENCE_GAP}.`,
82+
);
83+
nextSequenceNumber += MSFAA_SEQUENCE_GAP;
7984
this.logger.log("Creating MSFAA request content...");
8085
// Create the Request content for the MSFAA file by populating the
8186
// header, footer and trailer content.

sources/packages/backend/libs/services/src/constants/system-configurations-constants.ts

+5
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ export const ESDC_SIN_VALIDATION_SEQUENCE_GROUP_NAME = "ESDC_SIN_VALIDATION";
6363
*/
6464
export const MSFAA_FULL_TIME_FILE_CODE = "PBC.EDU.MSFA.SENT.";
6565
export const MSFAA_PART_TIME_FILE_CODE = "PBC.EDU.MSFA.SENT.PT.";
66+
/**
67+
* Sequence gap to be added to MSFAA sequence numbers to avoid conflicts
68+
* with the MSFAA sequence numbers generated by the legacy system.
69+
*/
70+
export const MSFAA_SEQUENCE_GAP = 9;
6671

6772
/**
6873
* Report the SFAS import progress every time that certain

0 commit comments

Comments
 (0)