#3222 - Provide Ministry the ability to edit Basic BCeID Profile Info (e2e tests) #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
changed the title
sh16011993
changed the title
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/api/src/route-controllers/student/models/student.dto.ts
Outdated
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Show resolved
Hide resolved
...controllers/student/_tests_/e2e/student.aest.controller.updateProfileInformation.e2e-spec.ts
Show resolved
Hide resolved
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
lewischen-aot
approved these changes
Oct 16, 2024
andrewsignori-aot
approved these changes
Oct 16, 2024
sh16011993
deleted the
3222_provide_ministry_ability_to_edit_basic_bceid_profile_info_e2e_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following e2e tests were written:
StudentAESTController(e2e)-updateProfileInformation√ Should allow the student profile update when the student is a Basic BCeID user. (5472 ms)
√ Should throw an HTTP Unprocessable Entity (422) error when the student is not a Basic BCeID user. (2619 ms)
√ Should throw an HTTP Forbidden (403) error when the ministry user performing the profile update does not have the associated role. (497 ms)
√ Should throw an HTTP Unprocessable Entity (422) error when the student is a Basic BCeID user but none of the user profile information that needs to be updated has changed. (3076 ms)
√ Should throw an HTTP Not Found (404) error when the student does not exist. (514 ms)
√ Should throw an HTTP Bad Request error when some mandatory profile update information is missing from the payload. (7 ms)
√ Should allow the student profile update when the student is a Basic BCeID user and the givenNames is not provided. (4945 ms)
Screenshot of the passed e2e tests: